All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org,
	Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Subject: [PATCH 4.8 04/10] Staging: fbtft: Fix bug in fbtft-core
Date: Thu,  6 Oct 2016 10:18:27 +0200	[thread overview]
Message-ID: <20161006074741.086371472@linuxfoundation.org> (raw)
In-Reply-To: <20161006074740.913116523@linuxfoundation.org>

4.8-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>

commit fc1e2c8ea85e109acf09e74789e9b852f6eed251 upstream.

Commit 367e8560e8d7a62d96e9b1d644028a3816e04206 introduced a bug
in fbtft-core where fps is always 0, this is because variable
update_time is not assigned correctly.

Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
Fixes: 367e8560e8d7 ("Staging: fbtbt: Replace timespec with ktime_t")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/staging/fbtft/fbtft-core.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/drivers/staging/fbtft/fbtft-core.c
+++ b/drivers/staging/fbtft/fbtft-core.c
@@ -391,11 +391,11 @@ static void fbtft_update_display(struct
 
 	if (unlikely(timeit)) {
 		ts_end = ktime_get();
-		if (ktime_to_ns(par->update_time))
+		if (!ktime_to_ns(par->update_time))
 			par->update_time = ts_start;
 
-		par->update_time = ts_start;
 		fps = ktime_us_delta(ts_start, par->update_time);
+		par->update_time = ts_start;
 		fps = fps ? 1000000 / fps : 0;
 
 		throughput = ktime_us_delta(ts_end, ts_start);

  parent reply	other threads:[~2016-10-06  8:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20161006081902uscas1p14629784f61bb4f76ecbc7f7298e4eeb3@uscas1p1.samsung.com>
2016-10-06  8:18 ` [PATCH 4.8 00/10] 4.8.1-stable review Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 01/10] arm64: debug: avoid resetting stepping state machine when TIF_SINGLESTEP Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 02/10] Using BUG_ON() as an assert() is _never_ acceptable Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 03/10] usb: misc: legousbtower: Fix NULL pointer deference Greg Kroah-Hartman
2016-10-06  8:18   ` Greg Kroah-Hartman [this message]
2016-10-06  8:18   ` [PATCH 4.8 05/10] usb: usbip: vudc: fix left shift overflow Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 06/10] USB: serial: cp210x: Add ID for a Juniper console Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 07/10] Revert "usbtmc: convert to devm_kzalloc" Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 08/10] ALSA: hda - Adding one more ALC255 pin definition for headset problem Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 09/10] ALSA: hda - Fix headset mic detection problem for several Dell laptops Greg Kroah-Hartman
2016-10-06  8:18   ` [PATCH 4.8 10/10] ALSA: hda - Add the top speaker pin config for HP Spectre x360 Greg Kroah-Hartman
2016-10-06 18:51   ` [PATCH 4.8 00/10] 4.8.1-stable review Guenter Roeck
2016-10-07  4:05     ` Greg Kroah-Hartman
2016-10-06 19:56   ` Shuah Khan
2016-10-07  4:05     ` Greg Kroah-Hartman
     [not found]   ` <57f820fc.4398c20a.3305b.cf51@mx.google.com>
2016-10-08 14:03     ` Greg Kroah-Hartman
2016-10-08 16:11       ` Kevin Hilman
2016-10-08 17:22         ` Guenter Roeck
2016-10-10  9:38           ` Mark Brown
2016-10-10 12:54             ` Guenter Roeck
2016-10-10 19:11               ` Mark Brown
2016-10-10 19:47                 ` Guenter Roeck
2016-10-11  7:24                   ` Mark Brown
2016-10-11 10:19                   ` Mark Brown
2016-10-11 13:37                     ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161006074741.086371472@linuxfoundation.org \
    --to=gregkh@linuxfoundation.org \
    --cc=ksenija.stanojevic@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.