From: Johan Hedberg <johan.hedberg@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Marcel Holtmann <marcel@holtmann.org>,
"Gustavo F. Padovan" <gustavo@padovan.org>,
"David S. Miller" <davem@davemloft.net>,
linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel
Date: Thu, 6 Oct 2016 11:38:04 +0300 [thread overview]
Message-ID: <20161006083804.GA2993@x1c.lan> (raw)
In-Reply-To: <1475737676.3224.1.camel@perches.com>
Hi,
On Thu, Oct 06, 2016, Joe Perches wrote:
> On Thu, 2016-10-06 at 09:02 +0200, Pavel Machek wrote:
> > I believe you are wrong. bit addressability does not matter, cpu can
> > definitely get the bit values.
> >
> > u8 foo:1;
> > u8 bar:1;
> > u8 baz:1;
> >
> > should take 1 byte, where
> >
> > bool foo, bar, baz;
> >
> > will take more like 3.
>
> Definitely true.
>
> There is only one single bitfield foo here though
> so what you wrote doesn't apply.
What's in the tree is a left-over from times when there were multiple
bit fields in this struct. By the time others were removed and there was
only one left no-one has apparently bothered to update it to a bool or
single u8.
Johan
next prev parent reply other threads:[~2016-10-06 8:38 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 8:56 [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel Pavel Machek
2016-10-05 11:14 ` Marcel Holtmann
2016-10-05 17:53 ` Joe Perches
2016-10-05 19:11 ` Pavel Machek
2016-10-05 19:11 ` Pavel Machek
2016-10-05 19:15 ` Joe Perches
2016-10-05 22:13 ` Pavel Machek
2016-10-05 22:28 ` Joe Perches
2016-10-06 7:02 ` Pavel Machek
2016-10-06 7:07 ` Joe Perches
2016-10-06 8:38 ` Johan Hedberg [this message]
2016-10-06 9:41 ` David Laight
2016-10-06 11:38 ` Joe Perches
2016-10-06 13:00 ` David Laight
2016-10-06 13:00 ` David Laight
2016-10-06 15:41 ` Joe Perches
2016-10-05 20:51 ` [PATCHv2] " Pavel Machek
2016-10-05 21:54 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006083804.GA2993@x1c.lan \
--to=johan.hedberg@gmail.com \
--cc=davem@davemloft.net \
--cc=gustavo@padovan.org \
--cc=joe@perches.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.