Re: [PATCH] efi: Use LocateHandleBuffer instead of LocateHandle

[Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>]

On Fri, Sep 09, 2016 at 11:52:32AM +0100, Ard Biesheuvel wrote:
> What is the oldest UEFI version we claim to support? For ARM, this is
> not an issue, but it appears that LocateHandleBuffer () was introduced
> in v1.10

UGA was apparently introduced with v1.10, GOP was introduced later
than v1.10, it follows that availability of LocateHandleBuffer()
can be assumed at least when searching for these two protocols.

Would a patch be entertained which uses LocateHandleBuffer for these
two but leaves the PCI ROM retrieval unchanged?


On Wed, Oct 05, 2016 at 05:25:44PM +0100, Ard Biesheuvel wrote:
> However, we've had our share of breakage with
> the stub code, which is difficult to debug on anything except
> development hardware, and so I think we should not take this change
> (and Matt appears to agree).

Thanks for the clarification, however I don't quite follow:
Is the rejection of the patch based on the intent to maintain
support for EFI v1.0+ (which isn't an argument for UGA + GOP
as lined out above) or is it based on a gut feeling that the
patch might cause breakage for whatever reason.
(Perhaps firmware bugs?  Not sure what is meant here.)

Thanks,

Lukas