From: Jiri Benc <jbenc@redhat.com>
To: Pravin Shelar <pshelar@ovn.org>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
Eric Garver <e@erig.me>
Subject: Re: [PATCH net-next v2 2/3] openvswitch: remove unreachable code in vlan parsing
Date: Thu, 6 Oct 2016 11:08:39 +0200 [thread overview]
Message-ID: <20161006110839.46c82fc4@griffin> (raw)
In-Reply-To: <CAOrHB_B+qUf9zOORG6KOUgew3g4hZxPNiexdMTLvtaCuQQy1oQ@mail.gmail.com>
On Wed, 5 Oct 2016 22:22:13 -0700, Pravin Shelar wrote:
> User can turn off TX vlan offload for OVS internal device that would
> allow vlan tagged packet with vlan header on the skb-data. This case
> will cause issue here.
Good catch. This is the feedback I hoped for, not the bikesheding about
a value of unused variable :-)
> We could handle this case by not allowing this configuration.
I'm not sure how clean this is but let's try and see if anyone objects.
I'll send v3.
I also noticed we don't set NETIF_F_HW_VLAN_STAG_TX on internal ports.
I'll fix it, too.
Thanks!
Jiri
next prev parent reply other threads:[~2016-10-06 9:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 13:07 [PATCH net-next v2 0/3] openvswitch: make vlan handling consistent Jiri Benc
2016-10-05 13:07 ` [PATCH net-next v2 1/3] openvswitch: normalize vlan rx path Jiri Benc
2016-10-05 14:18 ` Eyal Birger
2016-10-05 17:23 ` Jiri Benc
2016-10-05 17:31 ` Eyal Birger
2016-10-05 18:44 ` Eric Garver
2016-10-05 19:07 ` Jiri Benc
2016-10-05 19:21 ` Eric Garver
2016-10-05 21:07 ` Jiri Benc
2016-10-05 13:07 ` [PATCH net-next v2 2/3] openvswitch: remove unreachable code in vlan parsing Jiri Benc
2016-10-06 5:22 ` Pravin Shelar
2016-10-06 9:08 ` Jiri Benc [this message]
2016-10-05 13:07 ` [PATCH net-next v2 3/3] openvswitch: fix vlan subtraction from packet length Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006110839.46c82fc4@griffin \
--to=jbenc@redhat.com \
--cc=e@erig.me \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.