From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55775) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bs9q7-0004HY-HU for qemu-devel@nongnu.org; Thu, 06 Oct 2016 10:40:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bs9q3-0002K7-MV for qemu-devel@nongnu.org; Thu, 06 Oct 2016 10:40:03 -0400 Date: Thu, 6 Oct 2016 16:39:48 +0200 From: Kevin Wolf Message-ID: <20161006143948.GE5188@noname.redhat.com> References: <1475246744-29302-1-git-send-email-berrange@redhat.com> <1475246744-29302-7-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475246744-29302-7-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v14 06/21] qapi: don't pass two copies of TestInputVisitorData to tests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Markus Armbruster , Max Reitz , Paolo Bonzini , Andreas =?iso-8859-1?Q?F=E4rber?= Am 30.09.2016 um 16:45 hat Daniel P. Berrange geschrieben: > The input_visitor_test_add() method was accepting an instance > of 'TestInputVisitorData' and passing it as the 'user_data' > parameter to test functions. The main 'TestInputVisitorData' > instance that was actually used, was meanwhile being allocated > automatically by the test framework fixture setup. > > The 'user_data' parameter is going to be needed for tests > added in later patches, so getting rid of the current mistaken > usage now allows this. > > Signed-off-by: Daniel P. Berrange Reviewed-by: Kevin Wolf