From: Thierry Reding <thierry.reding@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-tegra@vger.kernel.org, Alexandre Courbot <gnurou@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: tegra: Fix argument order in tegra_pcie_phy_disable()
Date: Thu, 6 Oct 2016 16:49:34 +0200 [thread overview]
Message-ID: <20161006144934.GA800@ulmo.ba.sec> (raw)
In-Reply-To: <20161006134303.5595.9298.stgit@bhelgaas-glaptop2.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 554 bytes --]
On Thu, Oct 06, 2016 at 08:43:03AM -0500, Bjorn Helgaas wrote:
> The tegra_pcie_phy_disable() path called pads_writel() with arguments in
> the wrong order. Swap them to be the "value, offset" order expected by
> pads_writel().
>
> Fixes: 6fe7c187e026 ("PCI: tegra: Support per-lane PHYs")
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> CC: stable@vger.kernel.org # v4.7+
> ---
> drivers/pci/host/pci-tegra.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Good catch!
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-10-06 14:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 13:43 [PATCH] PCI: tegra: Fix argument order in tegra_pcie_phy_disable() Bjorn Helgaas
2016-10-06 14:49 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006144934.GA800@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=gnurou@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.