From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S942393AbcJFQxf (ORCPT ); Thu, 6 Oct 2016 12:53:35 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33100 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751645AbcJFQx1 (ORCPT ); Thu, 6 Oct 2016 12:53:27 -0400 From: Samuele Baisi To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, luisbg@osg.samsung.com, Samuele Baisi Subject: [PATCH] staging: lustre: lprocfs_status.h: fix sparse error: symbol redeclared with different type Date: Thu, 6 Oct 2016 18:52:07 +0200 Message-Id: <20161006165207.30061-1-ciccio87@gmail.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1554:5: error: symbol 'lprocfs_wr_root_squash' redeclared with different type (originally declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:704) - incompatible argument 1 (different address spaces) drivers/staging/lustre/lustre/obdclass/lprocfs_status.c:1618:5: error: symbol 'lprocfs_wr_nosquash_nids' redeclared with different type (originally declared at drivers/staging/lustre/lustre/obdclass/../include/lprocfs_status.h:706) - incompatible argument 1 (different address spaces) Added __user annotation to the header definitions arguments (which are indeed userspace buffers). Signed-off-by: Samuele Baisi --- drivers/staging/lustre/lustre/include/lprocfs_status.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/include/lprocfs_status.h b/drivers/staging/lustre/lustre/include/lprocfs_status.h index cc0713e..b5c24ca 100644 --- a/drivers/staging/lustre/lustre/include/lprocfs_status.h +++ b/drivers/staging/lustre/lustre/include/lprocfs_status.h @@ -701,9 +701,9 @@ static struct lustre_attr lustre_attr_##name = __ATTR(name, mode, show, store) extern const struct sysfs_ops lustre_sysfs_ops; struct root_squash_info; -int lprocfs_wr_root_squash(const char *buffer, unsigned long count, +int lprocfs_wr_root_squash(const char __user *buffer, unsigned long count, struct root_squash_info *squash, char *name); -int lprocfs_wr_nosquash_nids(const char *buffer, unsigned long count, +int lprocfs_wr_nosquash_nids(const char __user *buffer, unsigned long count, struct root_squash_info *squash, char *name); /* all quota proc functions */ -- 2.9.3