From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46924) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bsSGk-0004UQ-DT for qemu-devel@nongnu.org; Fri, 07 Oct 2016 06:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bsSGi-0000fv-80 for qemu-devel@nongnu.org; Fri, 07 Oct 2016 06:20:45 -0400 Date: Fri, 7 Oct 2016 12:20:37 +0200 From: Kevin Wolf Message-ID: <20161007102037.GE4589@noname.redhat.com> References: <1474984441-28516-1-git-send-email-kwolf@redhat.com> <1474984441-28516-11-git-send-email-kwolf@redhat.com> <1475830901.13132.23.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1475830901.13132.23.camel@redhat.com> Subject: Re: [Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org Am 07.10.2016 um 11:01 hat Gerd Hoffmann geschrieben: > On Di, 2016-09-27 at 15:53 +0200, Kevin Wolf wrote: > > This enables its use for nested child nodes. The compatibility > > between the 'discard' and 'detect-zeroes' setting is checked in > > bdrv_open_common() now as the former setting isn't available before > > calling bdrv_open() any more. > > Seems this change makes libvirt not see the discard option any more, > "virsh start" throws this error now ... > > error: Failed to start domain fedora-org-xhci > error: unsupported configuration: discard is not supported by this QEMU > binary > > ... and git bisect found this commit. The fix is already on the list: [PATCH] block: Add bdrv_runtime_opts to query-command-line-options Kevin