From: Riku Voipio <riku.voipio@iki.fi>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Felix Janda <felix.janda@posteo.de>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct mremap syscall
Date: Fri, 7 Oct 2016 12:19:08 +0000 [thread overview]
Message-ID: <20161007121908.GA28620@kos.to> (raw)
In-Reply-To: <CAFEAcA8ReFcEEtFW7owGrFYz=ZAP=SjED8G0Ur3WX4cFUw8rYw@mail.gmail.com>
On Fri, Sep 30, 2016 at 07:35:45PM -0700, Peter Maydell wrote:
> On 30 September 2016 at 16:39, Felix Janda <felix.janda@posteo.de> wrote:
> > This commit essentially reverts commit
> > 3af72a4d98dca033492102603734cbc63cd2694a, which has replaced
> > five-argument calls to mremap() by direct mremap syscalls for
> > compatibility with glibc older than version 2.4.
> >
> > The direct syscall was buggy for 64bit targets on 32bit hosts
> > because of the default integer type promotions. Since glibc-2.4
> > is now a decade old, we can remove this workaround.
> >
> > Signed-off-by: Felix Janda <felix.janda@posteo.de>
>
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Applied to linux-user, thanks
next prev parent reply other threads:[~2016-10-07 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 23:39 [Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct mremap syscall Felix Janda
2016-10-01 2:35 ` Peter Maydell
2016-10-07 12:19 ` Riku Voipio [this message]
2016-10-07 12:21 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007121908.GA28620@kos.to \
--to=riku.voipio@iki.fi \
--cc=felix.janda@posteo.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.