From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47948)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bsUrD-0002Ek-0B
	for qemu-devel@nongnu.org; Fri, 07 Oct 2016 09:06:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bsUr5-0001Et-Vn
	for qemu-devel@nongnu.org; Fri, 07 Oct 2016 09:06:33 -0400
Received: from jessie.kos.to ([212.47.231.226]:50516 helo=pilvi.kos.to)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <voipio@kos.to>) id 1bsUr5-00018U-PD
	for qemu-devel@nongnu.org; Fri, 07 Oct 2016 09:06:27 -0400
Date: Fri, 7 Oct 2016 13:06:21 +0000
From: Riku Voipio <riku.voipio@iki.fi>
Message-ID: <20161007130621.GE28620@kos.to>
References: <20160922165712.79809-1-aleksandar.markovic@rt-rk.com>
	<20160922165712.79809-4-aleksandar.markovic@rt-rk.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160922165712.79809-4-aleksandar.markovic@rt-rk.com>
Subject: Re: [Qemu-devel] [PATCH v7 03/10] linux-user: Add support for
 syncfs() syscall
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
Cc: qemu-devel@nongnu.org, laurent@vivier.eu, peter.maydell@linaro.org, petar.jovanovic@imgtec.com, miodrag.dinic@imgtec.com, aleksandar.rikalo@imgtec.com, aleksandar.markovic@imgtec.com

On Thu, Sep 22, 2016 at 06:56:52PM +0200, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> 
> This patch implements syncfs() syscall support. The implementation
> consists of a straightforward invocation of host's syncfs() only.
> 
> Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com>
> ---
>  linux-user/syscall.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 9f11ca2..1af3e10 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -8069,6 +8069,11 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
>          sync();
>          ret = 0;
>          break;
> +#if defined(TARGET_NR_syncfs)
> +    case TARGET_NR_syncfs:
> +        ret = get_errno(syncfs(arg1));
> +        break;
> +#endif

When compiling on Suse11:

linux-user/syscall.o: In function `do_syscall':
/work/linux-user/syscall.c:8090: undefined reference to `syncfs'

library support was added to glibc in version 2.14, which newer than
the glibc in the oldest distros qemu building is still supported (2.11
in Sles11).

CONFIG_SYNCFS checki and guard needed.

Riku

>      case TARGET_NR_kill:
>          ret = get_errno(safe_kill(arg1, target_to_host_signal(arg2)));
>          break;
> -- 
> 2.9.3
>