Re: [Outreachy kernel] Re: [PATCH] Staging: fsm-mc: bus: remove unused function modalias_show

[Greg KH <gregkh@linuxfoundation.org>]

On Fri, Oct 07, 2016 at 08:30:11PM +0530, Bhumika Goyal wrote:
> On Fri, Oct 7, 2016 at 8:24 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Oct 07, 2016 at 08:07:24PM +0530, Bhumika Goyal wrote:
> >> On Fri, Oct 7, 2016 at 8:02 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> > On Fri, Oct 07, 2016 at 07:56:51PM +0530, Bhumika Goyal wrote:
> >> >> The function modalias_show is not used anywhere in the kernel, so
> >> >> remove it. Done using Coccinelle:
> >> >>
> >> >> @r1@
> >> >> identifier func;
> >> >> type T;
> >> >> @@
> >> >> static T func(...)
> >> >> {
> >> >> ...
> >> >> }
> >> >>
> >> >> @r@
> >> >> identifier r1.func;
> >> >> @@
> >> >> func
> >> >>
> >> >> @delete depends on !r@
> >> >> identifier r1.func;
> >> >> type r1.T;
> >> >> @@
> >> >> - static T func(...){...}
> >> >>
> >> >> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> >> >> ---
> >> >>  drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 9 ---------
> >> >>  1 file changed, 9 deletions(-)
> >> >>
> >> >> diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
> >> >> index 44f64b6..e8bca6e 100644
> >> >> --- a/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
> >> >> +++ b/drivers/staging/fsl-mc/bus/fsl-mc-bus.c
> >> >> @@ -121,15 +121,6 @@ static int fsl_mc_bus_uevent(struct device *dev, struct kobj_uevent_env *env)
> >> >>
> >> >>       return 0;
> >> >>  }
> >> >> -
> >> >> -static ssize_t modalias_show(struct device *dev, struct device_attribute *attr,
> >> >> -                          char *buf)
> >> >> -{
> >> >> -     struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
> >> >> -
> >> >> -     return sprintf(buf, "fsl-mc:v%08Xd%s\n", mc_dev->obj_desc.vendor,
> >> >> -                    mc_dev->obj_desc.type);
> >> >> -}
> >> >>  static DEVICE_ATTR_RO(modalias);
> >> >
> >> > Um, it's used right there in the line you didn't delete.  Did you build
> >> > this code successfully with this change?
> >> >
> >> Yes, it did build successfully. I am confused that why didn't the
> >> build complain then ?
> >
> > Are you sure you built this file?  It's only usually built for an ARM
> > system...
> >
> My system's architecture is x86_64. And yes, it did build
> successfully. I did : make drivers/staging/fsl-mc/

And did a .o file get built from the .c file you modified?

Just because you tell the build system to build a subdir, doesn't mean
it builds all of the files in it.

thanks,

greg k-h