From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1757347AbcJGPb2 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 7 Oct 2016 11:31:28 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:59719 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757285AbcJGPbJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 7 Oct 2016 11:31:09 -0400
Date: Fri, 7 Oct 2016 17:31:16 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pantelis Antoniou <pantelis.antoniou@konsulko.com>
Cc: Debjit Ghosh <dghosh@juniper.net>, Georgi Vlaev <gvlaev@juniper.net>,
        Guenter Roeck <linux@roeck-us.net>,
        Mohammad Kamil <mkamil@juniper.net>,
        Rajat Jain <rajatjain@juniper.net>,
        Shyamshankar Dharmarajan <shyamd@juniper.net>,
        linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH 2/2] jnx: Introduce include/linux/jnx/pci_ids.h
Message-ID: <20161007153116.GD10482@kroah.com>
References: <1475853346-21890-1-git-send-email-pantelis.antoniou@konsulko.com>
 <1475853346-21890-3-git-send-email-pantelis.antoniou@konsulko.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1475853346-21890-3-git-send-email-pantelis.antoniou@konsulko.com>
User-Agent: Mutt/1.7.0 (2016-08-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Oct 07, 2016 at 06:15:46PM +0300, Pantelis Antoniou wrote:
> From: Rajat Jain <rajatjain@juniper.net>
> 
> Add this header to contain the PCI device IDs that we cannot add in
> the linux pci_ids.h.

Why can't you?

> This would contain PCI device IDs of Juniper devices as well as any
> PCIe switches etc.

Why do you need a .h file for this?  Is the values in it shared across
drivers?  If not, you don't nee a .h file at all.  If so, then it
belongs in pci_ids.h as the top of that file describes.

thanks,

greg k-h