All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Nadim Almas <nadim.902@gmail.com>
Cc: thomas.petazzoni@free-electrons.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding
Date: Fri, 7 Oct 2016 19:07:16 +0200	[thread overview]
Message-ID: <20161007170716.GB20665@kroah.com> (raw)
In-Reply-To: <20161007154302.GA4331@gmail.com>

On Fri, Oct 07, 2016 at 08:43:02AM -0700, Nadim Almas wrote:
> style issue
> 
> Fixed coding style issue

This does not seem like valid sentances that mean much to me.  Do they
to you?

> 
> Signed-off-by: Nadim Almas <nadim.902@gmail.com>
> ---
>  drivers/staging/fbtft/fb_s6d02a1.c | 30 ++++++++++++++++++++----------
>  1 file changed, 20 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/staging/fbtft/fb_s6d02a1.c b/drivers/staging/fbtft/fb_s6d02a1.c
> index 774b0ff..bc0c48f 100644
> --- a/drivers/staging/fbtft/fb_s6d02a1.c
> +++ b/drivers/staging/fbtft/fb_s6d02a1.c
> @@ -30,20 +30,27 @@ static int default_init_sequence[] = {
>  
>  	-1, 0xfc, 0x5a, 0x5a,
>  
> -	-1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A, 0x3A, 0x3A, 0x3d, 0x02, 0x01,
> +	-1, 0xfa, 0x02, 0x1f, 0x00, 0x10, 0x22, 0x30, 0x38, 0x3A, 0x3A, 0x3A,
> +						0x3A, 0x3A, 0x3d, 0x02, 0x01,

This looks worse to me now, remember, checkpatch.pl is a "hint", not a
hard-and-fast-rule.  Use it wisely.

greg k-h

  reply	other threads:[~2016-10-07 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-07 15:43 [PATCH] Staging:fbtft/fb_s6d02a1.c: fixed 80 character line limit coding Nadim Almas
2016-10-07 17:07 ` Greg KH [this message]
2016-10-07 18:55   ` Nadim Almas
2016-10-07 20:00     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161007170716.GB20665@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nadim.902@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.