From: Thierry Reding <thierry.reding@gmail.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
Stephen Warren <swarren@wwwdotorg.org>,
linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 2/5] PCI: tegra: Swap order of afi_writel() reg/val arguments
Date: Fri, 7 Oct 2016 19:21:58 +0200 [thread overview]
Message-ID: <20161007172158.GA10399@ulmo.ba.sec> (raw)
In-Reply-To: <20161007162624.23718.46538.stgit@bhelgaas-glaptop2.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Fri, Oct 07, 2016 at 11:26:24AM -0500, Bjorn Helgaas wrote:
> Swap order of afi_writel() arguments to match the "dev, pos, val"
> order used by pci_write_config_word() and other drivers. No functional
> change intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/pci/host/pci-tegra.c | 133 +++++++++++++++++++++---------------------
> 1 file changed, 66 insertions(+), 67 deletions(-)
Most Tegra drivers that I'm aware of follow the (value, offset) style of
the writel() function. But this is your turf, so if you prefer this for
consistency:
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-10-07 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 16:26 [PATCH 1/5] PCI: tegra: Fix argument order in tegra_pcie_phy_disable() Bjorn Helgaas
2016-10-07 16:26 ` [PATCH 2/5] PCI: tegra: Swap order of afi_writel() reg/val arguments Bjorn Helgaas
2016-10-07 16:26 ` Bjorn Helgaas
2016-10-07 17:21 ` Thierry Reding [this message]
2016-10-07 16:26 ` [PATCH 3/5] PCI: tegra: Swap order of pads_writel() " Bjorn Helgaas
2016-10-07 16:26 ` Bjorn Helgaas
2016-10-07 17:22 ` Thierry Reding
2016-10-07 17:22 ` Thierry Reding
2016-10-07 16:26 ` [PATCH 4/5] PCI: tegra: Add local struct device pointers Bjorn Helgaas
2016-10-07 17:22 ` Thierry Reding
2016-10-07 17:22 ` Thierry Reding
2016-10-07 16:26 ` [PATCH 5/5] PCI: tegra: Remove unused platform data Bjorn Helgaas
2016-10-07 16:26 ` Bjorn Helgaas
2016-10-07 17:24 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007172158.GA10399@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=bhelgaas@google.com \
--cc=gnurou@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.