All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: eblake@redhat.com, armbru@redhat.com, kwolf@redhat.com,
	qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh
Date: Sat, 8 Oct 2016 11:54:50 +0100	[thread overview]
Message-ID: <20161008105450.GY11243@redhat.com> (raw)
In-Reply-To: <1475923446-29428-1-git-send-email-ashijeetacharya@gmail.com>

On Sat, Oct 08, 2016 at 04:14:06PM +0530, Ashijeet Acharya wrote:
> Introduce new object 'BlockdevOptionsSsh' in qapi/block-core.json to
> support blockdev-add for SSH network protocol driver. Use only 'struct
> InetSocketAddress' since SSH only supports connection over TCP.
>  
> +##
> +# @BlockdevoptionsSsh
> +#
> +# @server:              host address and port number
> +#
> +# @path:                path to the image on the host
> +#
> +# @user:                user as which to connect
> +#
> +# @host_key_check       defines how and what to check the host key against
> +#
> +# Since 2.8
> +##
> +{ 'struct': 'BlockdevoptionsSsh',
> +  'data': { 'server': 'InetSocketAddress',
> +            'path': 'str',
> +            'user': 'str',
> +            'host_key_check': 'str' } }
> +

This certainly reflects the current ssh settings.

If you really wanted to get into the down-and-dirty details, then
host_key_check has some structure.  "yes", "no", "sha1:..." and
others.  But probably we don't want all of that in the JSON.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org

  reply	other threads:[~2016-10-08 10:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-08 10:44 [Qemu-devel] [PATCH] qapi: allow blockdev-add for ssh Ashijeet Acharya
2016-10-08 10:54 ` Richard W.M. Jones [this message]
2016-10-08 11:06   ` Ashijeet Acharya
2016-10-10  9:15 ` Kevin Wolf
2016-10-10 10:48   ` Ashijeet Acharya
2016-10-10 11:31     ` Kevin Wolf
2016-10-10 11:54       ` Ashijeet Acharya
2016-10-10 12:53         ` Kevin Wolf
2016-10-10 12:57           ` Ashijeet Acharya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161008105450.GY11243@redhat.com \
    --to=rjones@redhat.com \
    --cc=armbru@redhat.com \
    --cc=ashijeetacharya@gmail.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.