All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net
Subject: Re: [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD
Date: Sat, 8 Oct 2016 16:36:52 +0200	[thread overview]
Message-ID: <20161008143652.GA5434@kroah.com> (raw)
In-Reply-To: <20161008143343.GA12126@euri>

On Sat, Oct 08, 2016 at 08:03:43PM +0530, Varsha Rao wrote:
> This patch fixes the checkpatch issue of CamelCase by replacing byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD.

Please wrap your changelog comments at 72 columns.

And why uppercase this variable?  That's horrid to read now, right?
Please read Documentation/CodingStyle for how to properly name variables
(hint, upper-case-only is for #defines, not variables.

> 
> Avoid CamelCase: <byVT3253InitTab_RFMD>

What does that mean?

thanks,

greg k-h


  reply	other threads:[~2016-10-08 14:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-08 14:33 [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with BYVT3253INITTAB_RFMD Varsha Rao
2016-10-08 14:36 ` Greg KH [this message]
2016-10-08 14:50   ` Varsha Rao
  -- strict thread matches above, loose matches on Subject: below --
2016-10-08 18:03 [PATCH] Staging: vt6655: Replace byVT3253InitTab_RFMD with byvt3253inittab_rfmd Varsha Rao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161008143652.GA5434@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=forest@alittletooquiet.net \
    --cc=outreachy-kernel@googlegroups.com \
    --cc=rvarsha016@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.