From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb
Date: Sat, 8 Oct 2016 19:01:12 +0300 [thread overview]
Message-ID: <20161008160112.GB25893@intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B542F6741@hasmsx108.ger.corp.intel.com>
On Sat, Oct 08, 2016 at 01:37:31PM +0000, Winkler, Tomas wrote:
> >
> > On Sat, Oct 08, 2016 at 02:59:39PM +0300, Tomas Winkler wrote:
> > > From: "Winkler, Tomas" <tomas.winkler@intel.com>
> > >
> > > Utilize runtime_pm for driving tpm crb idle states.
> > > The framework calls cmd_ready from the pm_runtime_resume handler and
> > > go idle from the pm_runtime_suspend handler.
> > > The TPM framework should wake the device before transmit and receive.
> > > In case the runtime_pm framework is not compiled in or enabled, the
> > > device will be in the permanent ready state.
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >
> > I would rather want the fix as a separate patch to make review + testing easier
> > (without and with). Thanks.
>
> But you've dropped the patches, so I've resent them.
> Can you do the diff yourself, just branch it off. it's really just few lines
Nope. I have only dropped the workaround.
/Jarkko
next prev parent reply other threads:[~2016-10-08 16:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 11:59 [PATCH v4 0/4] tpm/tpm_crb: implement power management Tomas Winkler
[not found] ` <1475927979-23484-1-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 11:59 ` [PATCH v4 1/4] tpm/tpm_crb: implement tpm crb idle state Tomas Winkler
2016-10-08 11:59 ` Tomas Winkler
[not found] ` <1475927979-23484-2-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 16:30 ` Jarkko Sakkinen
2016-10-08 16:30 ` Jarkko Sakkinen
2016-10-08 11:59 ` [PATCH 2/4] tmp/tpm_crb: fix Intel PTT hw bug during " Tomas Winkler
2016-10-08 11:59 ` Tomas Winkler
[not found] ` <1475927979-23484-3-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 12:50 ` Jarkko Sakkinen
2016-10-08 12:50 ` Jarkko Sakkinen
[not found] ` <20161008125003.GB10317-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 14:27 ` Winkler, Tomas
2016-10-08 14:27 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F6768-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-08 16:00 ` Jarkko Sakkinen
2016-10-08 16:00 ` Jarkko Sakkinen
[not found] ` <20161008160006.GA25893-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 16:42 ` Jason Gunthorpe
2016-10-08 16:42 ` Jason Gunthorpe
[not found] ` <20161008164203.GB29734-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2016-10-08 16:58 ` Winkler, Tomas
2016-10-08 16:58 ` Winkler, Tomas
2016-10-08 17:08 ` Jarkko Sakkinen
2016-10-08 17:08 ` Jarkko Sakkinen
2016-10-08 16:56 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F67C8-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-08 17:06 ` Jarkko Sakkinen
2016-10-08 17:06 ` Jarkko Sakkinen
[not found] ` <20161008170651.GA8747-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 17:27 ` Winkler, Tomas
2016-10-08 17:27 ` Winkler, Tomas
2016-10-08 18:53 ` [tpmdd-devel] " Winkler, Tomas
2016-10-08 11:59 ` [PATCH 3/4] tpm/tpm_crb: open code the crb_init into acpi_add Tomas Winkler
2016-10-08 11:59 ` Tomas Winkler
2016-10-08 11:59 ` [PATCH 4/4] tmp/tpm_crb: implement runtime pm for tpm_crb Tomas Winkler
2016-10-08 11:59 ` Tomas Winkler
[not found] ` <1475927979-23484-5-git-send-email-tomas.winkler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 12:47 ` Jarkko Sakkinen
2016-10-08 12:47 ` Jarkko Sakkinen
[not found] ` <20161008124708.GA10317-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 13:37 ` Winkler, Tomas
2016-10-08 13:37 ` Winkler, Tomas
2016-10-08 16:01 ` Jarkko Sakkinen [this message]
[not found] ` <20161008160112.GB25893-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-10-08 18:18 ` Winkler, Tomas
2016-10-08 18:18 ` Winkler, Tomas
[not found] ` <5B8DA87D05A7694D9FA63FD143655C1B542F684D-Jy8z56yoSI8MvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2016-10-08 18:43 ` Jarkko Sakkinen
2016-10-08 18:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161008160112.GB25893@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tomas.winkler@intel.com \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.