Re: [PATCH v3] staging: sm750fb: Replace printk() with pr_info().

[Elise Lennion <elise.lennion@gmail.com>]

On Thu, Oct 06, 2016 at 02:48:26PM +0200, Greg KH wrote:
> On Wed, Oct 05, 2016 at 05:52:47PM -0300, Elise Lennion wrote:
> > Fix checkpatch warning:
> > 
> > WARNING: printk() should include KERN_ facility level
> > 
> > New checkpatch warning appears after including KERN_ facility level.
> > 
> > Fix checkpatch warning:
> > 
> > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
> > 
> > Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
> > ---
> > 
> > v2: Fixed new checkpatch warning noted by Julia Lawall <julia.lawall@lip6.fr>
> > Reworked to use pr_info() instead of printk()
> > 
> >  drivers/staging/sm750fb/ddk750_help.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/sm750fb/ddk750_help.c b/drivers/staging/sm750fb/ddk750_help.c
> > index 9637dd3..475a943 100644
> > --- a/drivers/staging/sm750fb/ddk750_help.c
> > +++ b/drivers/staging/sm750fb/ddk750_help.c
> > @@ -11,7 +11,5 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)
> >  	devId750 = devId;
> >  	revId750 = revId;
> >  	if (revId == 0xfe)
> > -		printk("found sm750le\n");
> > +		pr_info("found sm750le\n");
> >  }
> > -
> > -
> 
> Why are you deleting these extra lines?
> 

I was fixing a checkpatch CHECK and forgot to put it in a different commit, sorry.

> And why can't you use dev_info() here instead of pr_info()?
> 
> thanks,
> 
> greg k-h

I didn't use dev_info() because I didn't find a reference to a device struct.

I searched about how to use dev_* and all examples I found passed a pointer to a device struct in the function call.

In this case, without the pointer, how can I find the device to pass to dev_info()?

thank you.

elise