From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
rajesh.borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH qedr 05/10] qedr: Add support for QP verbs
Date: Sun, 9 Oct 2016 09:27:07 +0300 [thread overview]
Message-ID: <20161009062707.GC9282@leon.nu> (raw)
In-Reply-To: <1475682483-9878-6-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Wed, Oct 05, 2016 at 06:47:58PM +0300, Ram Amrani wrote:
> Add support for Queue Pair verbs which adds, deletes,
> modifies and queries Queue Pairs.
>
> Signed-off-by: Rajesh Borundia <rajesh.borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Ram Amrani <Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
> ---
> + qp->wqe_wr_id = kcalloc(qp->sq.max_wr, sizeof(*qp->wqe_wr_id),
> + GFP_KERNEL);
> + if (!qp->wqe_wr_id) {
> + DP_ERR(dev, "create qp: failed SQ shadow memory allocation\n");
> + return -ENOMEM;
> + }
Please remove prints for ENOMEM failures for all code. k*alloc
interfaces will print it for you.
Thanks
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-10-09 6:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 15:47 [PATCH qedr 00/10] QLogic RDMA Driver (qedr) Ram Amrani
[not found] ` <1475682483-9878-1-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-10-05 15:47 ` [PATCH qedr 01/10] qedr: Add RoCE driver framework Ram Amrani
2016-10-05 15:47 ` [PATCH qedr 02/10] qedr: Add support for RoCE HW init Ram Amrani
2016-10-05 15:47 ` [PATCH qedr 03/10] qedr: Add support for user context verbs Ram Amrani
2016-10-05 15:47 ` [PATCH qedr 04/10] qedr: Add support for PD,PKEY and CQ verbs Ram Amrani
[not found] ` <1475682483-9878-5-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-10-06 13:33 ` Leon Romanovsky
[not found] ` <20161006133357.GP9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-06 18:34 ` Amrani, Ram
2016-10-07 10:47 ` Elior, Ariel
[not found] ` <CY1PR0701MB1337AC7B933E917765C3EBC990C60-UpKza+2NMNLi6bjPjkn3FE5OhdzP3rhOnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-10-07 14:24 ` Leon Romanovsky
[not found] ` <20161007142454.GU9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-08 13:35 ` Doug Ledford
[not found] ` <a146f562-1970-e939-1bd5-074af868f7d6-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-10-08 15:39 ` Leon Romanovsky
[not found] ` <20161008153942.GY9282-2ukJVAZIZ/Y@public.gmane.org>
2016-10-08 23:20 ` Elior, Ariel
2016-10-10 6:34 ` Amrani, Ram
[not found] ` <SN1PR07MB22070099EE40A67B81D14C75F8DB0-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2016-10-10 7:24 ` Leon Romanovsky
2016-10-05 15:47 ` [PATCH qedr 05/10] qedr: Add support for QP verbs Ram Amrani
[not found] ` <1475682483-9878-6-git-send-email-Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org>
2016-10-09 6:27 ` Leon Romanovsky [this message]
2016-10-05 15:47 ` [PATCH qedr 06/10] qedr: Add support for memory registeration verbs Ram Amrani
2016-10-05 15:48 ` [PATCH qedr 07/10] qedr: Add support for data path Ram Amrani
2016-10-05 15:48 ` [PATCH qedr 08/10] qedr: Add LL2 RoCE interface Ram Amrani
2016-10-05 15:48 ` [PATCH qedr 09/10] qedr: Add GSI support Ram Amrani
2016-10-05 15:48 ` [PATCH qedr 10/10] qedr: Add events support and register IB device Ram Amrani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009062707.GC9282@leon.nu \
--to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=Ariel.Elior-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Michal.Kalderon-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Ram.Amrani-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=Yuval.Mintz-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rajesh.borundia-YGCgFSpz5w/QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.