From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH] net/virtio: add missing driver name Date: Sun, 9 Oct 2016 14:42:49 +0800 Message-ID: <20161009064249.GO1597@yliu-dev.sh.intel.com> References: <1475845393-25670-1-git-send-email-david.marchand@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Marchand , thomas.monjalon@6wind.com, dev@dpdk.org, huawei.xie@intel.com To: Shreyansh Jain Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id B4132378B for ; Sun, 9 Oct 2016 08:41:58 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 07, 2016 at 06:57:41PM +0530, Shreyansh Jain wrote: > On Friday 07 October 2016 06:33 PM, David Marchand wrote: > >The driver name has been lost with the eal rework. > >Restore it. > > > >Fixes: c830cb295411 ("drivers: use PCI registration macro") > > > >Signed-off-by: David Marchand > >--- > > drivers/net/virtio/virtio_ethdev.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > >diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > >index b4dfc0a..809ebf7 100644 > >--- a/drivers/net/virtio/virtio_ethdev.c > >+++ b/drivers/net/virtio/virtio_ethdev.c > >@@ -1304,6 +1304,9 @@ eth_virtio_dev_uninit(struct rte_eth_dev *eth_dev) > > > > static struct eth_driver rte_virtio_pmd = { > > .pci_drv = { > >+ .driver = { > >+ .name = "net_virtio", > >+ }, > > .id_table = pci_id_virtio_map, > > .drv_flags = RTE_PCI_DRV_DETACHABLE, > > .probe = rte_eth_dev_pci_probe, > > > > Indeed. For MLX4/5 and Virtio, DRIVER_REGISTER_* is not being used which > takes this 'name'. In this case, it was missed. > > Acked-by: Shreyansh Jain Applied to dpdk-next-virtio. Thanks. --yliu