From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Sun, 9 Oct 2016 15:49:10 +0800 Subject: [PATCH v2 1/2] dt-bindings: add bindings doc for ZTE VOU display controller In-Reply-To: <20161003174429.GA26054@rob-hp-laptop> References: <1474727185-24180-1-git-send-email-shawn.guo@linaro.org> <1474727185-24180-2-git-send-email-shawn.guo@linaro.org> <20161003174429.GA26054@rob-hp-laptop> Message-ID: <20161009074910.GA15400@tiger> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 03, 2016 at 12:44:29PM -0500, Rob Herring wrote: > > +Example: > > + > > +vou: vou at 1440000 { > > + compatible = "zte,zx296718-vou"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + reg = <0x1440000 0x10000>; > > + ranges; > > You still have overlapping addresses. Explicitly list the sub ranges in > reg here used by the VOU driver if the driver usage doesn't overlap. If > there is overlap (2 drivers accessing the same range), then you need > some APIs between the components (or possibly regmap). The driver matching "zte,zx296718-vou" doesn't map or access the any 'reg' address. The 'reg' property here is more like a hint telling that the VOU block covers the address space of all child devices. I will simply drop the 'reg' property here. > Also, don't do an empty ranges here. Fill it in so the child nodes are > just offsets of 0x1440000 Okay. I thought that empty 'ranges' is fine as long as parent and child address spaces are identical (1:1 mapping). So with your suggestion, I made the changes below. Let me know if this is still not what you are asking for. Shawn -----8<----------------- diff --git a/Documentation/devicetree/bindings/display/zte,vou.txt b/Documentation/devicetree/bindings/display/zte,vou.txt index d03ba4c4810c..6bb4ab2517ef 100644 --- a/Documentation/devicetree/bindings/display/zte,vou.txt +++ b/Documentation/devicetree/bindings/display/zte,vou.txt @@ -56,14 +56,13 @@ vou: vou@1440000 { compatible = "zte,zx296718-vou"; #address-cells = <1>; #size-cells = <1>; - reg = <0x1440000 0x10000>; - ranges; + ranges = <0 0x1440000 0x10000>; - dpc: dpc at 1440000 { + dpc: dpc at 0 { compatible = "zte,zx296718-dpc"; - reg = <0x1440000 0x1000>, <0x1441000 0x1000>, - <0x1445000 0x1000>, <0x1446000 0x1000>, - <0x144a000 0x1000>; + reg = <0x0000 0x1000>, <0x1000 0x1000>, + <0x5000 0x1000>, <0x6000 0x1000>, + <0xa000 0x1000>; reg-names = "osd", "timing_ctrl", "dtrc", "vou_ctrl", "otfppu"; @@ -74,9 +73,9 @@ vou: vou at 1440000 { "main_wclk", "aux_wclk"; }; - hdmi: hdmi at 144c000 { + hdmi: hdmi at c000 { compatible = "zte,zx296718-hdmi"; - reg = <0x144c000 0x4000>; + reg = <0xc000 0x4000>; interrupts = ; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v2 1/2] dt-bindings: add bindings doc for ZTE VOU display controller Date: Sun, 9 Oct 2016 15:49:10 +0800 Message-ID: <20161009074910.GA15400@tiger> References: <1474727185-24180-1-git-send-email-shawn.guo@linaro.org> <1474727185-24180-2-git-send-email-shawn.guo@linaro.org> <20161003174429.GA26054@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161003174429.GA26054@rob-hp-laptop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring Cc: Mark Rutland , devicetree@vger.kernel.org, Daniel Vetter , Baoyou Xie , dri-devel@lists.freedesktop.org, Jun Nie , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gTW9uLCBPY3QgMDMsIDIwMTYgYXQgMTI6NDQ6MjlQTSAtMDUwMCwgUm9iIEhlcnJpbmcgd3Jv dGU6Cj4gPiArRXhhbXBsZToKPiA+ICsKPiA+ICt2b3U6IHZvdUAxNDQwMDAwIHsKPiA+ICsJY29t cGF0aWJsZSA9ICJ6dGUsengyOTY3MTgtdm91IjsKPiA+ICsJI2FkZHJlc3MtY2VsbHMgPSA8MT47 Cj4gPiArCSNzaXplLWNlbGxzID0gPDE+Owo+ID4gKwlyZWcgPSA8MHgxNDQwMDAwIDB4MTAwMDA+ Owo+ID4gKwlyYW5nZXM7Cj4gCj4gWW91IHN0aWxsIGhhdmUgb3ZlcmxhcHBpbmcgYWRkcmVzc2Vz LiBFeHBsaWNpdGx5IGxpc3QgdGhlIHN1YiByYW5nZXMgaW4gCj4gcmVnIGhlcmUgdXNlZCBieSB0 aGUgVk9VIGRyaXZlciBpZiB0aGUgZHJpdmVyIHVzYWdlIGRvZXNuJ3Qgb3ZlcmxhcC4gSWYgCj4g dGhlcmUgaXMgb3ZlcmxhcCAoMiBkcml2ZXJzIGFjY2Vzc2luZyB0aGUgc2FtZSByYW5nZSksIHRo ZW4geW91IG5lZWQgCj4gc29tZSBBUElzIGJldHdlZW4gdGhlIGNvbXBvbmVudHMgKG9yIHBvc3Np Ymx5IHJlZ21hcCkuCgpUaGUgZHJpdmVyIG1hdGNoaW5nICJ6dGUsengyOTY3MTgtdm91IiBkb2Vz bid0IG1hcCBvciBhY2Nlc3MgdGhlIGFueQoncmVnJyBhZGRyZXNzLiAgVGhlICdyZWcnIHByb3Bl cnR5IGhlcmUgaXMgbW9yZSBsaWtlIGEgaGludCB0ZWxsaW5nCnRoYXQgdGhlIFZPVSBibG9jayBj b3ZlcnMgdGhlIGFkZHJlc3Mgc3BhY2Ugb2YgYWxsIGNoaWxkIGRldmljZXMuCgpJIHdpbGwgc2lt cGx5IGRyb3AgdGhlICdyZWcnIHByb3BlcnR5IGhlcmUuCgo+IEFsc28sIGRvbid0IGRvIGFuIGVt cHR5IHJhbmdlcyBoZXJlLiBGaWxsIGl0IGluIHNvIHRoZSBjaGlsZCBub2RlcyBhcmUgCj4ganVz dCBvZmZzZXRzIG9mIDB4MTQ0MDAwMAoKT2theS4gIEkgdGhvdWdodCB0aGF0IGVtcHR5ICdyYW5n ZXMnIGlzIGZpbmUgYXMgbG9uZyBhcyBwYXJlbnQgYW5kIGNoaWxkCmFkZHJlc3Mgc3BhY2VzIGFy ZSBpZGVudGljYWwgKDE6MSBtYXBwaW5nKS4KClNvIHdpdGggeW91ciBzdWdnZXN0aW9uLCBJIG1h ZGUgdGhlIGNoYW5nZXMgYmVsb3cuICBMZXQgbWUga25vdyBpZiB0aGlzCmlzIHN0aWxsIG5vdCB3 aGF0IHlvdSBhcmUgYXNraW5nIGZvci4KClNoYXduCgotLS0tLTg8LS0tLS0tLS0tLS0tLS0tLS0K CmRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS96 dGUsdm91LnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3p0 ZSx2b3UudHh0CmluZGV4IGQwM2JhNGM0ODEwYy4uNmJiNGFiMjUxN2VmIDEwMDY0NAotLS0gYS9E b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS96dGUsdm91LnR4dAorKysg Yi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS96dGUsdm91LnR4dApA QCAtNTYsMTQgKzU2LDEzIEBAIHZvdTogdm91QDE0NDAwMDAgewogICAgICAgIGNvbXBhdGlibGUg PSAienRlLHp4Mjk2NzE4LXZvdSI7CiAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47CiAgICAg ICAgI3NpemUtY2VsbHMgPSA8MT47Ci0gICAgICAgcmVnID0gPDB4MTQ0MDAwMCAweDEwMDAwPjsK LSAgICAgICByYW5nZXM7CisgICAgICAgcmFuZ2VzID0gPDAgMHgxNDQwMDAwIDB4MTAwMDA+Owog Ci0gICAgICAgZHBjOiBkcGNAMTQ0MDAwMCB7CisgICAgICAgZHBjOiBkcGNAMCB7CiAgICAgICAg ICAgICAgICBjb21wYXRpYmxlID0gInp0ZSx6eDI5NjcxOC1kcGMiOwotICAgICAgICAgICAgICAg cmVnID0gPDB4MTQ0MDAwMCAweDEwMDA+LCA8MHgxNDQxMDAwIDB4MTAwMD4sCi0gICAgICAgICAg ICAgICAgICAgICA8MHgxNDQ1MDAwIDB4MTAwMD4sIDwweDE0NDYwMDAgMHgxMDAwPiwKLSAgICAg ICAgICAgICAgICAgICAgIDwweDE0NGEwMDAgMHgxMDAwPjsKKyAgICAgICAgICAgICAgIHJlZyA9 IDwweDAwMDAgMHgxMDAwPiwgPDB4MTAwMCAweDEwMDA+LAorICAgICAgICAgICAgICAgICAgICAg PDB4NTAwMCAweDEwMDA+LCA8MHg2MDAwIDB4MTAwMD4sCisgICAgICAgICAgICAgICAgICAgICA8 MHhhMDAwIDB4MTAwMD47CiAgICAgICAgICAgICAgICByZWctbmFtZXMgPSAib3NkIiwgInRpbWlu Z19jdHJsIiwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICJkdHJjIiwgInZvdV9jdHJsIiwK ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJvdGZwcHUiOwpAQCAtNzQsOSArNzMsOSBAQCB2 b3U6IHZvdUAxNDQwMDAwIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIm1haW5fd2Ns ayIsICJhdXhfd2NsayI7CiAgICAgICAgfTsKIAotICAgICAgIGhkbWk6IGhkbWlAMTQ0YzAwMCB7 CisgICAgICAgaGRtaTogaGRtaUBjMDAwIHsKICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAi enRlLHp4Mjk2NzE4LWhkbWkiOwotICAgICAgICAgICAgICAgcmVnID0gPDB4MTQ0YzAwMCAweDQw MDA+OworICAgICAgICAgICAgICAgcmVnID0gPDB4YzAwMCAweDQwMDA+OwogICAgICAgICAgICAg ICAgaW50ZXJydXB0cyA9IDxHSUNfU1BJIDgyIElSUV9UWVBFX0VER0VfUklTSU5HPjsKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=