From: Greg KH <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net
Subject: Re: [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe
Date: Sun, 9 Oct 2016 15:50:44 +0200 [thread overview]
Message-ID: <20161009135044.GA30914@kroah.com> (raw)
In-Reply-To: <20161008112506.GA12694@euri>
On Sat, Oct 08, 2016 at 04:55:06PM +0530, Varsha Rao wrote:
> This patch fixes the checkpatch issue by replacing BBvClearFOE with bbvclearfoe.
> Avoid CamelCase: <BBvClearFOE>
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> drivers/staging/vt6655/baseband.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> index 6d9a936..a732fba 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -58,7 +58,7 @@
> #define TOP_RATE_2M 0x00200000
> #define TOP_RATE_1M 0x00100000
>
> -#define BBvClearFOE(dwIoBase) \
> +#define bbvclearfoe(dwIoBase) \
> BBbWriteEmbedded(dwIoBase, 0xB1, 0)
As this isn't used at all, why not just remove it?
thanks,
greg k-h
prev parent reply other threads:[~2016-10-09 13:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 11:25 [PATCH] staging: vt6655: Replace BBvClearFOE by bbvclearfoe Varsha Rao
2016-10-08 17:41 ` [Outreachy kernel] " Julia Lawall
2016-10-08 18:09 ` Varsha Rao
2016-10-08 20:10 ` Varsha Rao
2016-10-09 13:54 ` Julia Lawall
2016-10-11 20:00 ` Varsha Rao
2016-10-11 20:22 ` Julia Lawall
2016-10-12 3:54 ` Varsha Rao
2016-10-12 5:11 ` Julia Lawall
2016-10-13 12:18 ` Varsha Rao
2016-10-13 12:20 ` Julia Lawall
2016-10-13 12:37 ` Varsha Rao
2016-10-13 12:49 ` Greg KH
2016-10-13 12:52 ` Vaishali Thakkar
2016-10-13 16:01 ` Varsha Rao
2016-10-13 13:15 ` Julia Lawall
2016-10-13 16:08 ` Varsha Rao
2016-10-13 12:24 ` Greg KH
2016-10-13 12:25 ` Greg KH
2016-10-13 12:32 ` Varsha Rao
2016-10-09 13:50 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009135044.GA30914@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=outreachy-kernel@googlegroups.com \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.