From: Greg KH <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net
Subject: Re: [PATCH] Staging: vt6655: Rename dwIoBase as iobase
Date: Sun, 9 Oct 2016 15:57:19 +0200 [thread overview]
Message-ID: <20161009135719.GC30914@kroah.com> (raw)
In-Reply-To: <20161008194005.GA18035@euri>
On Sun, Oct 09, 2016 at 01:10:05AM +0530, Varsha Rao wrote:
> In this patch dwIoBase is renamed as iobase.
> This is done to fix the checkpatch issue of CamelCase.
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> drivers/staging/vt6655/baseband.c | 52 +++---
> drivers/staging/vt6655/baseband.h | 8 +-
> drivers/staging/vt6655/card.c | 30 ++--
> drivers/staging/vt6655/mac.h | 322 +++++++++++++++++++-------------------
> drivers/staging/vt6655/rf.c | 64 ++++----
> drivers/staging/vt6655/srom.c | 32 ++--
> drivers/staging/vt6655/srom.h | 6 +-
> 7 files changed, 257 insertions(+), 257 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c
> index 08dbce7..dae1e87 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -1916,7 +1916,7 @@ void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
> *
> * Parameters:
> * In:
> - * dwIoBase - I/O base address
> + * iobase - I/O base address
> * byBBAddr - address of register in Baseband
> * Out:
> * pbyData - data read
Minor nit, this isn't a parameter to the function at all. Perhaps you
can go through and fix them all up to have the proper data (or just
remove them, they are pretty pointless...)
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-09 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 19:40 [PATCH] Staging: vt6655: Rename dwIoBase as iobase Varsha Rao
2016-10-09 13:57 ` Greg KH [this message]
2016-10-09 14:04 ` Greg KH
2016-10-09 19:54 ` Varsha Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009135719.GC30914@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=outreachy-kernel@googlegroups.com \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.