From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/upmpdcli: add patch to fix error not detecting jsoncpp
Date: Sun, 9 Oct 2016 14:33:57 +0200 [thread overview]
Message-ID: <20161009143357.56643d6b@free-electrons.com> (raw)
In-Reply-To: <20160925141152.13952-1-joerg.krause@embedded.rocks>
Hello,
On Sun, 25 Sep 2016 16:11:52 +0200, J?rg Krause wrote:
> Fixes:
> http://autobuild.buildroot.net/results/205463c9ea8651911972c2835e28ded1912c811a
> http://autobuild.buildroot.net/results/5e9279ee60c11a3dacacf6d78f87f8d1b92968f5
> http://autobuild.buildroot.net/results/97043f8defd5a59ae39b4c7f095a10d15c7fe632
> http://autobuild.buildroot.net/results/e775126d5939093289b1a833dd6323ac293322ed
> .. and many more.
>
> libmpdclient, libmicrohttpd and jsoncpp provide a .pc file. Use
> pkg-config for detecting the libraries and for providing the necessary
> details for compiling and linking.
>
> The current build system of upmpdcli does not use PKG_CHECK_MODULES, but
> AC_LINK_IFELSE to detect jsoncpp. After bumping jsoncpp version from
> 1.7.2 to 1.7.5 the detection fails, because the test program does not
> compile anymore:
>
> """
> In file included from
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/autolink.h:9:0,
> from
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/json.h:9,
> from test.c:1:
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/config.h:155:9:
> error: 'int64_t' does not name a type
> typedef int64_t Int64;
> ^
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/config.h:156:9:
> error: 'uint64_t' does not name a type
> typedef uint64_t UInt64;
> ^
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/config.h:158:9:
> error: 'Int64' does not name a type
> typedef Int64 LargestInt;
> ^
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/config.h:159:9:
> error: 'UInt64' does not name a type
> typedef UInt64 LargestUInt;
> ^
> In file included from
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/json.h:10:0,
> from test.c:1:
> /usr/arm-buildroot-linux-gnueabi/sysroot/usr/include/json/value.h:184:11:
> error: 'UInt64' in namespace 'Json' does not name a type
> typedef Json::UInt64 UInt64;
>
> [..]
> """
>
> Instead of fixing the test program use PKG_CHECK_MODULES to check for
> jsoncpp. While we're on it, add it for libmpdclient and libmicrohttpd,
> too.
>
> Upstream-status: https://github.com/medoc92/upmpdcli/pull/52
>
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
> v2:
> - fix typo in patch
> ---
> ...ig-for-jsoncpp-libmpdclient-libmicrohttpd.patch | 105 +++++++++++++++++++++
> 1 file changed, 105 insertions(+)
> create mode 100644 package/upmpdcli/0004-Use-pkg-config-for-jsoncpp-libmpdclient-libmicrohttpd.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-09 12:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 14:11 [Buildroot] [PATCH v2] package/upmpdcli: add patch to fix error not detecting jsoncpp Jörg Krause
2016-10-09 12:33 ` Thomas Petazzoni [this message]
2016-10-11 19:32 ` Peter Korsgaard
2016-10-11 19:38 ` Jörg Krause
2016-10-11 19:53 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161009143357.56643d6b@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.