All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Juliana Rodrigues <juliana.orod@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks
Date: Sun, 9 Oct 2016 16:41:13 +0200	[thread overview]
Message-ID: <20161009144113.GA25227@kroah.com> (raw)
In-Reply-To: <20161008204844.GA8624@spock>

On Sat, Oct 08, 2016 at 05:48:44PM -0300, Juliana Rodrigues wrote:
> This patch fixes lines over 80 characters that were causing checkpatch
> issues and rewrites some comment blocks to match coding style.

Do not do multiple different things in the same patch, break it up into
one-type-of-thing-per-patch.

thanks,

greg k-h


  parent reply	other threads:[~2016-10-09 14:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1475959255.git.juliana.orod@gmail.com>
2016-10-08 20:48 ` [PATCH 1/4] staging: rtl8188eu: core: removes unecessary parenthesis Juliana Rodrigues
2016-10-08 20:48 ` [PATCH 2/4] staging: rtl8188eu: core: formats long lines and comment blocks Juliana Rodrigues
2016-10-09  5:55   ` [Outreachy kernel] " Julia Lawall
2016-10-09 14:41   ` Greg KH [this message]
2016-10-08 20:49 ` [PATCH 3/4] staging: rtl8188eu: core: removes extra blank lines Juliana Rodrigues
2016-10-09  5:50   ` [Outreachy kernel] " Julia Lawall
2016-10-09 14:41   ` Greg KH
2016-10-08 20:49 ` [PATCH 4/4] staging: rtl8188eu: core: fixes tabstop alignment Juliana Rodrigues

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009144113.GA25227@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=juliana.orod@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.