Re: [PATCH]V2 /staging/dgnc/dgnc_neo.h. Lines less than 80 characters

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Sat, Oct 08, 2016 at 01:44:03AM +0200, Keila wrote:
> Signed-off-by: Keila Novo <laurana5@gmail.com>

Why did you put this as the first line?

> 
> Version 2. Fix checkpatch "more than 80 characters
> per line"

Why is "Version 2" in the changelog text here?

And look at your Subject:, it doesn't match other subjects for this
driver, does it?

> 
> Signed-off-by: Keila Novo <laurana5@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_neo.h | 35 +++++++++++++++++++----------------
>  1 file changed, 19 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.h b/drivers/staging/dgnc/dgnc_neo.h
> index abddd48..efc88fd 100644
> --- a/drivers/staging/dgnc/dgnc_neo.h
> +++ b/drivers/staging/dgnc/dgnc_neo.h
> @@ -28,27 +28,27 @@
>   ************************************************************************/
>  
>  struct neo_uart_struct {
> -	u8 txrx;		/* WR  RHR/THR - Holding Reg */
> +	u8 txrx;	/* WR  RHR/THR - Holding Reg */
>  	u8 ier;		/* WR  IER - Interrupt Enable Reg */
> -	u8 isr_fcr;		/* WR  ISR/FCR - Interrupt Status Reg/Fifo Control Reg */
> +	u8 isr_fcr;    /* WR ISR/FCR - Interrupt Status Reg/Fifo Control Reg */

Why did you switch to using spaces?  Things are now not lined up neatly
:(

thanks,

greg k-h