All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: pci_alloc_irq_vectors use in 8250_lpss.c
Date: Sun, 9 Oct 2016 19:56:15 +0200	[thread overview]
Message-ID: <20161009175615.GA22239@lst.de> (raw)

Hi Andy,

two comment on your ぱatch to add MSI support to the above driver.

First pci_alloc_irq_vectors gained a mandatory flags argument, so
for MSI suport you now need to pass PCI_IRQ_MSI in flags for the
code to work.

Second please make sure to always pair pci_alloc_irq_vectors
with pci_free_irq_vectors on the remove path.

Thanks,
	Christoph

             reply	other threads:[~2016-10-09 17:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-09 17:56 Christoph Hellwig [this message]
2016-10-09 22:01 ` pci_alloc_irq_vectors use in 8250_lpss.c Andy Shevchenko
2016-10-09 22:20   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009175615.GA22239@lst.de \
    --to=hch@lst.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.