All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org,
	"Stefano Stabellini" <stefano.stabellini@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] tests: use accel=best instead of accel=kvm:tcg
Date: Sun, 9 Oct 2016 23:50:10 +0300	[thread overview]
Message-ID: <20161009235000-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1475580648-6470-3-git-send-email-lvivier@redhat.com>

On Tue, Oct 04, 2016 at 01:30:48PM +0200, Laurent Vivier wrote:
> This avoids to have logs polluted by "kvm accelerator not found".
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>


Acked-by: Michael S. Tsirkin <mst@redhat.com>


> ---
>  tests/bios-tables-test.c | 2 +-
>  tests/postcopy-test.c    | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/bios-tables-test.c b/tests/bios-tables-test.c
> index 7e27ea9..497dd56 100644
> --- a/tests/bios-tables-test.c
> +++ b/tests/bios-tables-test.c
> @@ -716,7 +716,7 @@ static void test_acpi_one(const char *params, test_data *data)
>                             "-net none -display none %s "
>                             "-drive id=hd0,if=none,file=%s,format=raw "
>                             "-device ide-hd,drive=hd0 ",
> -                           data->machine, "kvm:tcg",
> +                           data->machine, "best",
>                             params ? params : "", disk);
>  
>      qtest_start(args);
> diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
> index 41ed1a9..d549d5e 100644
> --- a/tests/postcopy-test.c
> +++ b/tests/postcopy-test.c
> @@ -368,12 +368,12 @@ static void test_migrate(void)
>  
>      if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
>          init_bootfile_x86(bootpath);
> -        cmd_src = g_strdup_printf("-machine accel=kvm:tcg -m 150M"
> +        cmd_src = g_strdup_printf("-machine accel=best -m 150M"
>                                    " -name pcsource,debug-threads=on"
>                                    " -serial file:%s/src_serial"
>                                    " -drive file=%s,format=raw",
>                                    tmpfs, bootpath);
> -        cmd_dst = g_strdup_printf("-machine accel=kvm:tcg -m 150M"
> +        cmd_dst = g_strdup_printf("-machine accel=best -m 150M"
>                                    " -name pcdest,debug-threads=on"
>                                    " -serial file:%s/dest_serial"
>                                    " -drive file=%s,format=raw"
> @@ -381,12 +381,12 @@ static void test_migrate(void)
>                                    tmpfs, bootpath, uri);
>      } else if (strcmp(arch, "ppc64") == 0) {
>          init_bootfile_ppc(bootpath);
> -        cmd_src = g_strdup_printf("-machine accel=kvm:tcg -m 256M"
> +        cmd_src = g_strdup_printf("-machine accel=best -m 256M"
>                                    " -name pcsource,debug-threads=on"
>                                    " -serial file:%s/src_serial"
>                                    " -drive file=%s,if=pflash,format=raw",
>                                    tmpfs, bootpath);
> -        cmd_dst = g_strdup_printf("-machine accel=kvm:tcg -m 256M"
> +        cmd_dst = g_strdup_printf("-machine accel=best -m 256M"
>                                    " -name pcdest,debug-threads=on"
>                                    " -serial file:%s/dest_serial"
>                                    " -incoming %s",
> -- 
> 2.7.4

  reply	other threads:[~2016-10-09 20:50 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-04 11:30 [Qemu-devel] [PATCH 0/2] introduce "accel=best" Laurent Vivier
2016-10-04 11:30 ` [Qemu-devel] [PATCH 1/2] accel: allows to select the "best" accelerator Laurent Vivier
2016-10-04 12:00   ` Daniel P. Berrange
2016-10-04 12:29     ` Laurent Vivier
2016-10-04 12:32     ` Peter Maydell
2016-10-04 12:41   ` Paolo Bonzini
2016-10-04 12:49     ` Thomas Huth
2016-10-04 13:31       ` Daniel P. Berrange
2016-10-04 14:18         ` Thomas Huth
2016-10-04 17:16           ` Paolo Bonzini
2016-10-05  1:13             ` Michael S. Tsirkin
2016-10-05  7:21               ` Paolo Bonzini
2016-10-05  7:00             ` Thomas Huth
2016-10-05  7:48               ` Paolo Bonzini
2016-10-04 11:30 ` [Qemu-devel] [PATCH 2/2] tests: use accel=best instead of accel=kvm:tcg Laurent Vivier
2016-10-09 20:50   ` Michael S. Tsirkin [this message]
2016-10-04 11:35 ` [Qemu-devel] [PATCH 0/2] introduce "accel=best" Laurent Vivier
2016-10-04 12:00 ` Andrew Jones
2016-10-04 12:07   ` Daniel P. Berrange
2016-10-04 12:26     ` Andrew Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161009235000-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.