Re: [PATCH V2] i40iw: Add Quality of Service support

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 785 bytes --]

On Fri, Oct 07, 2016 at 03:47:47PM -0500, Henry Orosco wrote:

<...>

>
>  	switch (iwdev->init_state) {
>  	case RDMA_DEV_REGISTERED:
> @@ -1628,6 +1642,7 @@ static int i40iw_open(struct i40e_info *ldev, struct i40e_client *client)
>  		iwdev->init_state = RDMA_DEV_REGISTERED;
>  		iwdev->iw_status = 1;
>  		i40iw_port_ibevent(iwdev);
> +		iwdev->param_wq = create_singlethread_workqueue("l2params");
>  		i40iw_pr_info("i40iw_open completed\n");

No, please don't use this interface, For reference, see latest work from Bhaktipriya
Shridhar to eliminate this call. Doug and Dave sent a pull request with it to Linus in
last merge cycle.

Also, 1) you should check if this call succeeded and 2) ask yourself if
special workqueue is needed.

>  		return 0;
>  	} while (0);

Thanks.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]