From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbcJJFnD (ORCPT ); Mon, 10 Oct 2016 01:43:03 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38499 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbcJJFnC (ORCPT ); Mon, 10 Oct 2016 01:43:02 -0400 Date: Mon, 10 Oct 2016 07:43:09 +0200 From: Greg KH To: Joe Perches Cc: Sabitha George , wsa+renesas@sang-engineering.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2] staging: ks7010: use netdev_* instead of printk() Message-ID: <20161010054309.GB23806@kroah.com> References: <1476030845-8674-1-git-send-email-sabitha.george@gmail.com> <1476035186.2856.9.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476035186.2856.9.camel@perches.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 09, 2016 at 10:46:26AM -0700, Joe Perches wrote: > On Sun, 2016-10-09 at 22:04 +0530, Sabitha George wrote: > > Fixes checkpatch warning on printk usage in ks_hostif.c > [] > > diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c > [] > > @@ -465,8 +465,7 @@ void hostif_data_indication(struct ks_wlan_private *priv) > > skb->dev->last_rx = jiffies; > > netif_rx(skb); > > } else { > > - printk(KERN_WARNING > > - "ks_wlan: Memory squeeze, dropping packet.\n"); > > + netdev_warn(priv->net_dev, "ks_wlan: Memory squeeze, dropping packet.\n"); > > You could probably drop all the "ks_wlan: " prefixes here > and the rx_dropped increase generally removes the need > for a non-rate-limited warning message so these > memory squeeze messages could be removed as well. I agree, ks_wlan: should be removed. thanks, greg k-h