All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mihaela Muraru <mihaela.muraru21@gmail.com>
Cc: Aditya Shankar <aditya.shankar@microchip.com>,
	Ganesh Krishna <ganesh.krishna@microchip.com>,
	outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Stagin: wilc1000: Use ether_addr_copy() rather memcpy()
Date: Mon, 10 Oct 2016 09:44:07 +0200	[thread overview]
Message-ID: <20161010074407.GA10568@kroah.com> (raw)
In-Reply-To: <20161010073505.GA7227@domino-MS-16Y1>

On Mon, Oct 10, 2016 at 10:35:05AM +0300, Mihaela Muraru wrote:
> This patch fixs up a issue found it by  checkpatch.pl tool.
> 
> WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet
> addresses are __aligned(2).
> 
> Check if the addresses are aligned with pahole.
> 
> struct sta_inactive_t {
> 	u8                         mac[6];               /*     0     6
> */

Odd wrapping of changelog comments, please fix this up and resend.

And also, your subject line has a typo :)

thanks,

greg k-h


  reply	other threads:[~2016-10-10  7:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  7:35 [PATCH] Stagin: wilc1000: Use ether_addr_copy() rather memcpy() Mihaela Muraru
2016-10-10  7:44 ` Greg Kroah-Hartman [this message]
2016-10-10  7:46 ` [Outreachy kernel] " Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161010074407.GA10568@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aditya.shankar@microchip.com \
    --cc=ganesh.krishna@microchip.com \
    --cc=mihaela.muraru21@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.