All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Elise Lennion <elise.lennion@gmail.com>
Cc: lidza.louina@gmail.com, markh@compro.net,
	outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro with dgnc_verify_board function.
Date: Mon, 10 Oct 2016 10:19:48 +0200	[thread overview]
Message-ID: <20161010081948.GA11548@kroah.com> (raw)
In-Reply-To: <20161010043825.GA5438@lennorien.com>

On Mon, Oct 10, 2016 at 01:38:25AM -0300, Elise Lennion wrote:
> Fix checkpatch warning:
> 
> WARNING: Macros with flow control statements should be avoided
> 
> Macros with flow control statements should be avoided; they break the flow of the calling function and make it harder to test the code.

Please always wrap your changelog comments at 72 columns.

thanks,

greg k-h


      parent reply	other threads:[~2016-10-10  8:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  4:38 [PATCH] staging: dgnc: replace DGNC_VERIFY_BOARD macro with dgnc_verify_board function Elise Lennion
2016-10-10  6:39 ` [Outreachy kernel] " Julia Lawall
2016-10-10  8:19 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161010081948.GA11548@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=elise.lennion@gmail.com \
    --cc=lidza.louina@gmail.com \
    --cc=markh@compro.net \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.