From: Greg KH <gregkh@linuxfoundation.org>
To: Varsha Rao <rvarsha016@gmail.com>
Cc: outreachy-kernel@googlegroups.com, forest@alittletooquiet.net
Subject: Re: [Patch v2] Staging: vt6655: Replace dwIoBase by iobase
Date: Mon, 10 Oct 2016 10:25:02 +0200 [thread overview]
Message-ID: <20161010082502.GA19439@kroah.com> (raw)
In-Reply-To: <CAAFX7JT4acPoN+yGojG6jrfXB5y=73rFhRP46t+pTZv==tj=nQ@mail.gmail.com>
On Mon, Oct 10, 2016 at 12:45:17AM +0530, Varsha Rao wrote:
> In this patch dwIoBase is renamed as iobase.This is done to fix the
> checkpatch issue of the CamelCase.
Please put a space after a . in a sentance.
>
> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
> Changes in v2:
> -Limited commit message line to 70 characters.
> -Proper alignment of different comments.
>
> drivers/staging/vt6655/baseband.c | 52 +++---
> drivers/staging/vt6655/baseband.h | 8 +-
> drivers/staging/vt6655/card.c | 30 ++--
> drivers/staging/vt6655/mac.h | 322 +++++++++++++++++++-------------------
> drivers/staging/vt6655/rf.c | 64 ++++----
> drivers/staging/vt6655/srom.c | 32 ++--
> drivers/staging/vt6655/srom.h | 6 +-
> 7 files changed, 257 insertions(+), 257 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.c
> b/drivers/staging/vt6655/baseband.c
> index ba051ff..1ab91f9 100644
> --- a/drivers/staging/vt6655/baseband.c
> +++ b/drivers/staging/vt6655/baseband.c
> @@ -1914,7 +1914,7 @@ void vnt_get_phy_field(struct vnt_private *priv,
> u32 frame_length,
Your patch is line-wrapped and can not be applied :(
How did that happen? Are you using 'git send-email' or something else?
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-10 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 19:15 [Patch v2] Staging: vt6655: Replace dwIoBase by iobase Varsha Rao
2016-10-10 8:25 ` Greg KH [this message]
2016-10-11 11:35 ` Varsha Rao
-- strict thread matches above, loose matches on Subject: below --
2016-10-15 10:20 [PATCH " Varsha Rao
2016-10-08 18:55 [Patch " varsha Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010082502.GA19439@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=outreachy-kernel@googlegroups.com \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.