From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Muraru Mihaela <mihaela.muraru21@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [PATCH v2] Staging: ks7010: Replace printk with netdev_*
Date: Mon, 10 Oct 2016 10:36:58 +0200 [thread overview]
Message-ID: <20161010083658.GA2343@kroah.com> (raw)
In-Reply-To: <20161010082846.GA8819@domino-MS-16Y1>
On Mon, Oct 10, 2016 at 11:28:46AM +0300, Muraru Mihaela wrote:
> On Mon, Oct 10, 2016 at 09:09:13AM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Oct 09, 2016 at 11:39:37PM +0300, Mihaela Muraru wrote:
> > > This is a patch to ks_hostif.c file that fixes up a checkpatch.pl
> > >
> > > WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then
> > > dev_info(dev, ... then pr_info(... to printk(KERN_INFO ...
> > >
> > > For netdev devices netdev_info and netdev_warn is preferred over
> > > printk(KERN_INFO/WARN..).
> > >
> > > Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> > >
> > > ---
> > > Changes in v2:
> > > -rebase the staging-testing branch
> >
> > Really? It still does not apply :(
> >
> > Note, many people seem to be working on this same file, in the same
> > area, for some reason...
>
> Thank you for reply.
>
> I saw that this file has a lot of problems and because of that I will
> rebase it again and I will resend it,if is ok for you. It is a small
> contribution, but it can improve something.
Yes, please continue working on this file if you want to, I am always
willing to accept patches.
I just know it can get frustrating when multiple people work in the same
place, as someone always ends up getting their patch rejected.
thanks,
greg k-h
next prev parent reply other threads:[~2016-10-10 8:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-09 20:39 [PATCH v2] Staging: ks7010: Replace printk with netdev_* Mihaela Muraru
2016-10-10 7:09 ` Greg Kroah-Hartman
2016-10-10 8:28 ` Muraru Mihaela
2016-10-10 8:36 ` Greg Kroah-Hartman [this message]
2016-10-10 8:41 ` Muraru Mihaela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010083658.GA2343@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=mihaela.muraru21@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.