From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH v3 11/12] scsi/ncr5380: Use correct types for DMA routines Date: Mon, 10 Oct 2016 10:15:41 +0100 Message-ID: <20161010091541.GX1041@n2100.armlinux.org.uk> References: <8390541e30d7b7cd418a7b5095fdb4b5fc7aa0ed.1476051962.git.fthain@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <8390541e30d7b7cd418a7b5095fdb4b5fc7aa0ed.1476051962.git.fthain@telegraphics.com.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Finn Thain Cc: Michael Schmitz , Ondrej Zary , linux-scsi@vger.kernel.org, "Martin K. Petersen" , linux-kernel@vger.kernel.org, "James E.J. Bottomley" , linux-arm-kernel@lists.infradead.org List-Id: linux-scsi@vger.kernel.org On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote: > Apply prototypes to get consistent function signatures for the DMA > functions implemented in the board-specific drivers. To avoid using > macros to alter actual parameters, some of those functions are reworked > slightly. > > This is a step toward the goal of passing the board-specific routines > to the core driver using an ops struct (as in a platform driver or > library module). > > This also helps fix some inconsistent types: where the core driver uses > ints (cmd->SCp.this_residual and hostdata->dma_len) for keeping track of > transfers, certain board-specific routines used unsigned long. > > While we are fixing these function signatures, pass the hostdata pointer > to DMA routines instead of a Scsi_Host pointer, for shorter and faster > code. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke > Tested-by: Ondrej Zary > Tested-by: Michael Schmitz > --- > drivers/scsi/arm/cumana_1.c | 26 ++++++++++------ > drivers/scsi/arm/oak.c | 13 ++++---- For these two, Acked-by: Russell King Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@armlinux.org.uk (Russell King - ARM Linux) Date: Mon, 10 Oct 2016 10:15:41 +0100 Subject: [PATCH v3 11/12] scsi/ncr5380: Use correct types for DMA routines In-Reply-To: <8390541e30d7b7cd418a7b5095fdb4b5fc7aa0ed.1476051962.git.fthain@telegraphics.com.au> References: <8390541e30d7b7cd418a7b5095fdb4b5fc7aa0ed.1476051962.git.fthain@telegraphics.com.au> Message-ID: <20161010091541.GX1041@n2100.armlinux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote: > Apply prototypes to get consistent function signatures for the DMA > functions implemented in the board-specific drivers. To avoid using > macros to alter actual parameters, some of those functions are reworked > slightly. > > This is a step toward the goal of passing the board-specific routines > to the core driver using an ops struct (as in a platform driver or > library module). > > This also helps fix some inconsistent types: where the core driver uses > ints (cmd->SCp.this_residual and hostdata->dma_len) for keeping track of > transfers, certain board-specific routines used unsigned long. > > While we are fixing these function signatures, pass the hostdata pointer > to DMA routines instead of a Scsi_Host pointer, for shorter and faster > code. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke > Tested-by: Ondrej Zary > Tested-by: Michael Schmitz > --- > drivers/scsi/arm/cumana_1.c | 26 ++++++++++------ > drivers/scsi/arm/oak.c | 13 ++++---- For these two, Acked-by: Russell King Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbcJJJTN (ORCPT ); Mon, 10 Oct 2016 05:19:13 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:58922 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751790AbcJJJTL (ORCPT ); Mon, 10 Oct 2016 05:19:11 -0400 Date: Mon, 10 Oct 2016 10:15:41 +0100 From: Russell King - ARM Linux To: Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-arm-kernel@lists.infradead.org, Michael Schmitz , Ondrej Zary , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 11/12] scsi/ncr5380: Use correct types for DMA routines Message-ID: <20161010091541.GX1041@n2100.armlinux.org.uk> References: <8390541e30d7b7cd418a7b5095fdb4b5fc7aa0ed.1476051962.git.fthain@telegraphics.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8390541e30d7b7cd418a7b5095fdb4b5fc7aa0ed.1476051962.git.fthain@telegraphics.com.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote: > Apply prototypes to get consistent function signatures for the DMA > functions implemented in the board-specific drivers. To avoid using > macros to alter actual parameters, some of those functions are reworked > slightly. > > This is a step toward the goal of passing the board-specific routines > to the core driver using an ops struct (as in a platform driver or > library module). > > This also helps fix some inconsistent types: where the core driver uses > ints (cmd->SCp.this_residual and hostdata->dma_len) for keeping track of > transfers, certain board-specific routines used unsigned long. > > While we are fixing these function signatures, pass the hostdata pointer > to DMA routines instead of a Scsi_Host pointer, for shorter and faster > code. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke > Tested-by: Ondrej Zary > Tested-by: Michael Schmitz > --- > drivers/scsi/arm/cumana_1.c | 26 ++++++++++------ > drivers/scsi/arm/oak.c | 13 ++++---- For these two, Acked-by: Russell King Thanks. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.