From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: david@fromorbit.com, linux-xfs@vger.kernel.org,
Brian Foster <bfoster@redhat.com>
Subject: Re: [PATCH 3/7] xfs: reduce stack usage of _reflink_clear_inode_flag
Date: Mon, 10 Oct 2016 03:17:00 -0700 [thread overview]
Message-ID: <20161010101700.GA18359@infradead.org> (raw)
In-Reply-To: <147588165809.12127.6624984020251009472.stgit@birch.djwong.org>
On Fri, Oct 07, 2016 at 04:07:38PM -0700, Darrick J. Wong wrote:
> The loop in _reflink_clear_inode_flag isn't necessary since we
> jump out if any part of any extent is shared. Remove the loop
> and we no longer need two maps, so we can save some stack use.
I have a patch that gets rid of the xfs_bmapi_read calls entirely
and instead does an initial xfs_bmap_search_extents and then iterates
over the extent index.
It also uses xfs_reflink_trim_around_shared instead of opencoding
it.
It didn't plan to submit it now as it seemed to superficial for 4.9,
I can't dust it off if you want.
next prev parent reply other threads:[~2016-10-10 10:17 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 23:07 [PATCH 0/7] xfs: reflink fixes Darrick J. Wong
2016-10-07 23:07 ` [PATCH 1/7] xfs: rework refcount cow recovery error handling Darrick J. Wong
2016-10-10 5:37 ` Dave Chinner
2016-10-10 6:10 ` Darrick J. Wong
2016-10-10 6:11 ` [PATCH v2 " Darrick J. Wong
2016-10-10 10:21 ` Christoph Hellwig
2016-10-10 18:21 ` Darrick J. Wong
2016-10-10 20:25 ` Dave Chinner
2016-10-10 21:46 ` Darrick J. Wong
2016-10-07 23:07 ` [PATCH 2/7] xfs: check inode reflink flag before calling reflink functions Darrick J. Wong
2016-10-10 5:24 ` Dave Chinner
2016-10-10 10:18 ` Christoph Hellwig
2016-10-07 23:07 ` [PATCH 3/7] xfs: reduce stack usage of _reflink_clear_inode_flag Darrick J. Wong
2016-10-10 5:25 ` Dave Chinner
2016-10-10 10:17 ` Christoph Hellwig [this message]
2016-10-07 23:07 ` [PATCH 4/7] xfs: remove isize check from unshare operation Darrick J. Wong
2016-10-10 5:26 ` Dave Chinner
2016-10-10 10:21 ` Christoph Hellwig
2016-10-07 23:07 ` [PATCH 5/7] xfs: fix label inaccuracies Darrick J. Wong
2016-10-10 5:27 ` Dave Chinner
2016-10-10 10:22 ` Christoph Hellwig
2016-10-07 23:07 ` [PATCH 6/7] xfs: fix error initialization Darrick J. Wong
2016-10-08 15:55 ` Eric Sandeen
2016-10-10 5:36 ` Dave Chinner
2016-10-10 10:23 ` Christoph Hellwig
2016-10-07 23:08 ` [PATCH 7/7] xfs: clear reflink flag if setting realtime flag Darrick J. Wong
2016-10-10 5:29 ` Dave Chinner
2016-10-10 10:24 ` Christoph Hellwig
2016-10-10 12:25 ` Dave Chinner
2016-10-10 12:45 ` Christoph Hellwig
2016-10-10 12:59 ` Dave Chinner
2016-10-10 17:18 ` Darrick J. Wong
2016-10-10 12:44 ` Brian Foster
2016-10-10 18:10 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010101700.GA18359@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.