Re: [PATCH 0/4] libfdt: A few overlay fixes

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1550 bytes --]

On Mon, Oct 10, 2016 at 12:08:19PM +0200, Maxime Ripard wrote:
> Hi David,
> 
> On Fri, Oct 07, 2016 at 03:08:35PM +1100, David Gibson wrote:
> > On Thu, Oct 06, 2016 at 01:39:55PM +0200, Maxime Ripard wrote:
> > > Hi David,
> > > 
> > > Here are a few patches to fix the things you requested and a few bugs
> > > encountered while doing so.
> > > 
> > > Let me know what you think,
> > 
> > All applied, thanks.
> 
> It doesn't look like it's on the repo, did you push it?

Oops, I did not.

Try now.

> > Couple of other little errors to correct if you have time:
> > 
> >   - BADOVERLAY is listed twice in the error string table (a hangover
> >     from when there was both BADFIXUP and BADOVERLAY, I guess)
> > 
> >   - The testcases re-use the same file name for the intermediate
> >     dtbs.  That's not a terrible problem, but it can make sorting out
> >     what's going on when there are multiple errors in a test run
> >     harder
> > 
> >   - Generated dtb/dts files during the test should generally have a
> >    .test.dtb / .test.dts extension (makes gitignores and clean targets
> >    easier)
> > 
> >   - In order for the apply_overlay function to be usable from the
> >     libfdt shared library, you'll need to add it to version.lds
> 
> I'll deal with those this week. Thanks!
> Maxime
> 



-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]