diff for duplicates of <20161010143146.GA8218@gmail.com> diff --git a/a/1.txt b/N1/1.txt index 68f2fb2..ac2ad79 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -18,7 +18,7 @@ On Fri, Oct 07, 2016 at 11:12:04AM +0200, Mike Rapoport wrote: > > > > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId) > > > > devId750 = devId; > > > > revId750 = revId; -> > > > if (revId = 0xfe) +> > > > if (revId == 0xfe) > > > > - printk("found sm750le\n"); > > > > + pr_info("found sm750le\n"); > > > @@ -49,7 +49,7 @@ Thanks, that makes sense. I tried deleting the if statement and printk() from ddk750_help.c, and adding the following in lynxfb_pci_probe() after calling hw_sm750_map() and checking for errors: -if (sm750_dev->revid = 0xfe) +if (sm750_dev->revid == 0xfe) dev_info(&pdev->dev, "found sm750le\n"); The driver compiles, loads and unloads ok with this code. diff --git a/a/content_digest b/N1/content_digest index 961c4f3..f7e19a9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\020161007091204.GA29629@rapoport-lnx\0" "From\0Edward Lipinsky <ellipinsky@gmail.com>\0" "Subject\0Re: [PATCH] staging: sm750fb: Fix printk() style warning\0" - "Date\0Mon, 10 Oct 2016 14:31:46 +0000\0" + "Date\0Mon, 10 Oct 2016 07:31:46 -0700\0" "To\0Mike Rapoport <mike.rapoport@gmail.com>\0" "Cc\0Greg KH <gregkh@linuxfoundation.org>" devel@driverdev.osuosl.org @@ -35,7 +35,7 @@ "> > > > @@ -11,7 +11,7 @@ void ddk750_set_mmio(void __iomem *addr, unsigned short devId, char revId)\n" "> > > > \tdevId750 = devId;\n" "> > > > \trevId750 = revId;\n" - "> > > > \tif (revId = 0xfe)\n" + "> > > > \tif (revId == 0xfe)\n" "> > > > -\t\tprintk(\"found sm750le\\n\");\n" "> > > > +\t\tpr_info(\"found sm750le\\n\");\n" "> > > \n" @@ -66,7 +66,7 @@ "from ddk750_help.c, and adding the following in lynxfb_pci_probe() after\n" "calling hw_sm750_map() and checking for errors:\n" "\n" - "if (sm750_dev->revid = 0xfe)\n" + "if (sm750_dev->revid == 0xfe)\n" "\tdev_info(&pdev->dev, \"found sm750le\\n\");\n" "\n" "The driver compiles, loads and unloads ok with this code.\n" @@ -76,4 +76,4 @@ "Regards,\n" Ed L. -eac8051647821133ea1f94dc73365064777828e0e0cfcfa2eccd4ef8bc3197d1 +24457f9161579ad9ac317dd3695a959d7dbab3efa7b434b5270d95d2b264b986
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.