From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54411) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btc5Z-0002a2-C9 for qemu-devel@nongnu.org; Mon, 10 Oct 2016 11:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btc5V-0003yR-2A for qemu-devel@nongnu.org; Mon, 10 Oct 2016 11:02:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51182) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btc5U-0003xi-SQ for qemu-devel@nongnu.org; Mon, 10 Oct 2016 11:01:56 -0400 Date: Mon, 10 Oct 2016 16:01:52 +0100 From: "Daniel P. Berrange" Message-ID: <20161010150152.GJ15488@redhat.com> Reply-To: "Daniel P. Berrange" References: <20160926101627.14296-1-lma@suse.com> <20160926101627.14296-2-lma@suse.com> <20160926103703.GF18393@redhat.com> <57FC170302000062000A2689@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] =?utf-8?b?562U5aSN77yaIFJlOiAgW1BBVENIIHYzIDEvM10g?= =?utf-8?q?qom=3A_make_base_type_user-creatable_abstract?= List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Lin Ma , qemu-devel@nongnu.org, armbru@redhat.com, afaerber@suse.de On Mon, Oct 10, 2016 at 04:45:56PM +0200, Paolo Bonzini wrote: > > > On 10/10/2016 16:32, Lin Ma wrote: > >>This doesn't make any conceptual sense. UserCreatable is an inteface and > >>by definition all interfaces are abstract. > > > > Sorry for the late reply, I was on vacation. > > oh...indeed, add '.abstract = true' for an interface is not a good idea. > > Perhaps Lin Ma's patch actually made some sense. If all interfaces are > abstract, why shouldn't object_class_is_abstract say so? object_class_is_abstract() should say so, but we should not have to express that manually when defining the interface - anything that is define as an interface should be automatically abstract Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|