From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 1/3] syscalls: new test writev07
Date: Mon, 10 Oct 2016 17:54:07 +0200 [thread overview]
Message-ID: <20161010155406.GF1684@rei> (raw)
In-Reply-To: <81176684cd5c6bf764a070b79783f03f0037658a.1475827191.git.jstancek@redhat.com>
Hi!
> + /* file content matches written bytes */
> + SAFE_LSEEK(fd, initial_file_offset, SEEK_SET);
> + SAFE_READ(1, fd, tmp, TEST_RETURN);
> + if (memcmp(tmp, wr_iovec[0].iov_base, TEST_RETURN) == 0) {
> + tst_res(TPASS, "file has expected content");
> + } else {
> + tst_res(TFAIL, "file has unexpected content");
> + tst_res(TINFO, "expected:");
^
This TINFO looks redundant now.
Otherwise it looks good, acked.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2016-10-10 15:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-07 8:11 [LTP] [PATCH v2 1/3] syscalls: new test writev07 Jan Stancek
2016-10-07 8:11 ` [LTP] [PATCH v2 2/3] writev: remove writev03 and writev04 Jan Stancek
2016-10-07 8:11 ` [LTP] [PATCH v2 3/3] writev01: rewrite and drop partially valid iovec tests Jan Stancek
2016-10-10 16:03 ` Cyril Hrubis
2016-10-11 7:39 ` Jan Stancek
2016-10-11 8:41 ` Cyril Hrubis
2016-10-11 10:18 ` Jan Stancek
2016-10-10 15:54 ` Cyril Hrubis [this message]
2016-12-01 6:36 ` [LTP] [PATCH v2 1/3] syscalls: new test writev07 Cui Bixuan
2016-12-01 7:36 ` Jan Stancek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010155406.GF1684@rei \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.