All of lore.kernel.org
 help / color / mirror / Atom feed
From: no-reply@patchew.org
To: arei.gonglei@huawei.com
Cc: famz@redhat.com, qemu-devel@nongnu.org,
	virtio-dev@lists.oasis-open.org, weidong.huang@huawei.com,
	claudio.fontana@huawei.com, mst@redhat.com, xin.zeng@intel.com,
	hanweidong@huawei.com, luonengjun@huawei.com, agraf@suse.de,
	nmorey@kalray.eu, mike.caraman@nxp.com, stefanha@redhat.com,
	jianjay.zhou@huawei.com, pbonzini@redhat.com,
	peter.huangpeng@huawei.com, vincent.jardin@6wind.com,
	wu.wubin@huawei.com, arei.gonglei@hotmail.com
Subject: Re: [Qemu-devel] [PATCH RESEND v6 00/12] virtio-crypto: introduce framework and device emulation
Date: Mon, 10 Oct 2016 09:15:03 -0700 (PDT)	[thread overview]
Message-ID: <20161010161458.498194.82181@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <1476089730-65776-1-git-send-email-arei.gonglei@huawei.com>

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: 1476089730-65776-1-git-send-email-arei.gonglei@huawei.com
Subject: [Qemu-devel] [PATCH RESEND v6 00/12] virtio-crypto: introduce framework and device emulation
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
47cfbc1 virtio-crypto: perfect algorithms chainning support
81a4d12 virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer
7ad32b1 cryptodev: introduce an unified wrapper for crypto operation
4714b3d virtio-crypto: add data queue processing handler
b61dfe7 virtio-crypto: add control queue handler
8b91458 virtio-crypto: set capacity of algorithms supported
c0f4d06 virtio-crypto-pci: add virtio crypto pci support
a7e5efe virtio-crypto: add virtio crypto device emulation
727ff7f cryptodev: introduce a new cryptodev backend
a7db317 virtio-crypto: introduce virtio_crypto.h
c2324a0 cryptodev: add symmetric algorithm operation stuff
a302606 cryptodev: introduce cryptodev backend interface

=== OUTPUT BEGIN ===
Checking PATCH 1/12: cryptodev: introduce cryptodev backend interface...
Checking PATCH 2/12: cryptodev: add symmetric algorithm operation stuff...
Checking PATCH 3/12: virtio-crypto: introduce virtio_crypto.h...
Checking PATCH 4/12: cryptodev: introduce a new cryptodev backend...
Checking PATCH 5/12: virtio-crypto: add virtio crypto device emulation...
Checking PATCH 6/12: virtio-crypto-pci: add virtio crypto pci support...
Checking PATCH 7/12: virtio-crypto: set capacity of algorithms supported...
Checking PATCH 8/12: virtio-crypto: add control queue handler...
Checking PATCH 9/12: virtio-crypto: add data queue processing handler...
ERROR: open brace '{' following struct go on the same line
#382: FILE: include/hw/virtio/virtio-crypto.h:41:
+struct virtio_crypto_inhdr
+{

total: 1 errors, 0 warnings, 373 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 10/12: cryptodev: introduce an unified wrapper for crypto operation...
Checking PATCH 11/12: virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer...
Checking PATCH 12/12: virtio-crypto: perfect algorithms chainning support...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org

  parent reply	other threads:[~2016-10-10 16:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10  8:55 [Qemu-devel] [PATCH RESEND v6 00/12] virtio-crypto: introduce framework and device emulation Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 01/12] cryptodev: introduce cryptodev backend interface Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 02/12] cryptodev: add symmetric algorithm operation stuff Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 03/12] virtio-crypto: introduce virtio_crypto.h Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 04/12] cryptodev: introduce a new cryptodev backend Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 05/12] virtio-crypto: add virtio crypto device emulation Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 06/12] virtio-crypto-pci: add virtio crypto pci support Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 07/12] virtio-crypto: set capacity of algorithms supported Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 08/12] virtio-crypto: add control queue handler Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 09/12] virtio-crypto: add data queue processing handler Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 10/12] cryptodev: introduce an unified wrapper for crypto operation Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 11/12] virtio-crypto: add myself as virtio-crypto and cryptodev backends maintainer Gonglei
2016-10-10  8:55 ` [Qemu-devel] [PATCH RESEND v6 12/12] virtio-crypto: perfect algorithms chainning support Gonglei
2016-10-10 16:15 ` no-reply [this message]
2016-10-11 10:46 ` [Qemu-devel] [PATCH RESEND v6 00/12] virtio-crypto: introduce framework and device emulation no-reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161010161458.498194.82181@ex-std-node742.prod.rhcloud.com \
    --to=no-reply@patchew.org \
    --cc=agraf@suse.de \
    --cc=arei.gonglei@hotmail.com \
    --cc=arei.gonglei@huawei.com \
    --cc=claudio.fontana@huawei.com \
    --cc=famz@redhat.com \
    --cc=hanweidong@huawei.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=luonengjun@huawei.com \
    --cc=mike.caraman@nxp.com \
    --cc=mst@redhat.com \
    --cc=nmorey@kalray.eu \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=vincent.jardin@6wind.com \
    --cc=virtio-dev@lists.oasis-open.org \
    --cc=weidong.huang@huawei.com \
    --cc=wu.wubin@huawei.com \
    --cc=xin.zeng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.