From: no-reply@patchew.org
To: eric.auger@redhat.com
Cc: peter.maydell@linaro.org, drjones@redhat.com, famz@redhat.com,
pranav.sawargaonkar@gmail.com, qemu-devel@nongnu.org,
Bharat.Bhushan@freescale.com, eric.auger@redhat.com,
alex.williamson@redhat.com, qemu-arm@nongnu.org,
diana.craciun@freescale.com, christoffer.dall@linaro.org,
eric.auger.pro@gmail.com
Subject: Re: [Qemu-arm] [Qemu-devel] [RFC v4 0/8] KVM PCI/MSI passthrough with mach-virt
Date: Mon, 10 Oct 2016 09:16:57 -0700 (PDT) [thread overview]
Message-ID: <20161010161653.498195.39878@ex-std-node742.prod.rhcloud.com> (raw)
In-Reply-To: <1475754090-22681-1-git-send-email-eric.auger@redhat.com>
Hi,
Your series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [RFC v4 0/8] KVM PCI/MSI passthrough with mach-virt
Message-id: 1475754090-22681-1-git-send-email-eric.auger@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
9fa6e4b hw: vfio: common: Adapt vfio_listeners for reserved_iova region
6f58b94 hw: vfio: common: vfio_prepare_msi_mapping
e73c1f9 hw: platform-bus: Enable to map any memory region onto the platform-bus
313b445 memory: memory_region_find_by_name
afe3c21 memory: Add reserved_iova region type
403f6a2 hw: vfio: common: Introduce vfio_register_msi_iova
30cd237 hw: vfio: common: vfio_get_iommu_type1_info
22e4efb linux-headers: Partial update for MSI IOVA handling
=== OUTPUT BEGIN ===
Checking PATCH 1/8: linux-headers: Partial update for MSI IOVA handling...
Checking PATCH 2/8: hw: vfio: common: vfio_get_iommu_type1_info...
Checking PATCH 3/8: hw: vfio: common: Introduce vfio_register_msi_iova...
ERROR: externs should be avoided in .c files
#32: FILE: hw/vfio/common.c:222:
+int vfio_register_msi_iova(VFIOContainer *container, hwaddr iova,
total: 1 errors, 0 warnings, 34 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/8: memory: Add reserved_iova region type...
Checking PATCH 5/8: memory: memory_region_find_by_name...
Checking PATCH 6/8: hw: platform-bus: Enable to map any memory region onto the platform-bus...
Checking PATCH 7/8: hw: vfio: common: vfio_prepare_msi_mapping...
Checking PATCH 8/8: hw: vfio: common: Adapt vfio_listeners for reserved_iova region...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@freelists.org
next prev parent reply other threads:[~2016-10-10 16:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 11:41 [Qemu-arm] [RFC v4 0/8] KVM PCI/MSI passthrough with mach-virt Eric Auger
2016-10-06 11:41 ` [Qemu-devel] [RFC v4 1/8] linux-headers: Partial update for MSI IOVA handling Eric Auger
2016-10-06 11:41 ` [Qemu-arm] [RFC v4 2/8] hw: vfio: common: vfio_get_iommu_type1_info Eric Auger
2016-10-06 11:41 ` [Qemu-arm] [RFC v4 3/8] hw: vfio: common: Introduce vfio_register_msi_iova Eric Auger
2016-10-06 11:41 ` [Qemu-arm] [RFC v4 4/8] memory: Add reserved_iova region type Eric Auger
2016-10-06 11:41 ` [Qemu-devel] [RFC v4 5/8] memory: memory_region_find_by_name Eric Auger
2016-10-06 11:41 ` [Qemu-arm] [RFC v4 6/8] hw: platform-bus: Enable to map any memory region onto the platform-bus Eric Auger
2016-10-06 11:41 ` [Qemu-arm] [RFC v4 7/8] hw: vfio: common: vfio_prepare_msi_mapping Eric Auger
2016-10-06 11:41 ` [Qemu-arm] [RFC v4 8/8] hw: vfio: common: Adapt vfio_listeners for reserved_iova region Eric Auger
2016-10-10 16:16 ` no-reply [this message]
2016-10-10 21:11 ` [Qemu-arm] [Qemu-devel] [RFC v4 0/8] KVM PCI/MSI passthrough with mach-virt no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161010161653.498195.39878@ex-std-node742.prod.rhcloud.com \
--to=no-reply@patchew.org \
--cc=Bharat.Bhushan@freescale.com \
--cc=alex.williamson@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=diana.craciun@freescale.com \
--cc=drjones@redhat.com \
--cc=eric.auger.pro@gmail.com \
--cc=eric.auger@redhat.com \
--cc=famz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pranav.sawargaonkar@gmail.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.