From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Snitzer <snitzer@redhat.com>
Subject: Re: dm raid1: "mirror" target doesn't use all available
 legs on multiple failures
Date: Mon, 10 Oct 2016 16:41:27 -0400
Message-ID: <20161010204126.GA20089@redhat.com>
References: <1476118086-2975-1-git-send-email-heinzm@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dm-devel-bounces@redhat.com>
Content-Disposition: inline
In-Reply-To: <1476118086-2975-1-git-send-email-heinzm@redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/dm-devel>
List-Post: <mailto:dm-devel@redhat.com>
List-Help: <mailto:dm-devel-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/dm-devel>,
	<mailto:dm-devel-request@redhat.com?subject=subscribe>
Sender: dm-devel-bounces@redhat.com
Errors-To: dm-devel-bounces@redhat.com
To: Heinz Mauelshagen <heinzm@redhat.com>
Cc: dm-devel@redhat.com
List-Id: dm-devel.ids

On Mon, Oct 10 2016 at 12:48pm -0400,
Heinz Mauelshagen <heinzm@redhat.com> wrote:

> In case legs of a "mirror" target fail, any read will cause a new,
> operational default leg to be selected and the read be resubmitted
> to it. If that new default leg fails the read too, no other still
> accessible legs are used to resubmit the read again thus failing
> the io.
> 
> Fix by allowing the read to get resubmitted until there's no
> operational legs any more.
> 
> Resolves: rhbz1383444
> 
> Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>

Nothing seems to be checking bio_record->details.bi_bdev anymore.
(The one you've removed really seems like a complete hack to begin with)

Shouldn't this patch go further by removing the other 2 places that set
bio_record->details.bi_bdev = NULL; ? 

> ---
>  drivers/md/dm-raid1.c | 11 -----------
>  1 file changed, 11 deletions(-)
> 
> diff --git a/drivers/md/dm-raid1.c b/drivers/md/dm-raid1.c
> index 7a6254d..dd31019 100644
> --- a/drivers/md/dm-raid1.c
> +++ b/drivers/md/dm-raid1.c
> @@ -1266,16 +1266,6 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, int error)
>  		goto out;
>  
>  	if (unlikely(error)) {
> -		if (!bio_record->details.bi_bdev) {
> -			/*
> -			 * There wasn't enough memory to record necessary
> -			 * information for a retry or there was no other
> -			 * mirror in-sync.
> -			 */
> -			DMERR_LIMIT("Mirror read failed.");
> -			return -EIO;
> -		}
> -
>  		m = bio_record->m;
>  
>  		DMERR("Mirror read failed from %s. Trying alternative device.",
> @@ -1291,7 +1281,6 @@ static int mirror_end_io(struct dm_target *ti, struct bio *bio, int error)
>  			bd = &bio_record->details;
>  
>  			dm_bio_restore(bd, bio);
> -			bio_record->details.bi_bdev = NULL;
>  			bio->bi_error = 0;
>  
>  			queue_bio(ms, bio, rw);
> -- 
> 2.7.4
>