From mboxrd@z Thu Jan 1 00:00:00 1970 From: robh@kernel.org (Rob Herring) Date: Mon, 10 Oct 2016 16:48:21 -0500 Subject: [PATCH v2 1/2] dt-bindings: add bindings doc for ZTE VOU display controller In-Reply-To: <20161009074910.GA15400@tiger> References: <1474727185-24180-1-git-send-email-shawn.guo@linaro.org> <1474727185-24180-2-git-send-email-shawn.guo@linaro.org> <20161003174429.GA26054@rob-hp-laptop> <20161009074910.GA15400@tiger> Message-ID: <20161010214821.GA17551@rob-hp-laptop> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, Oct 09, 2016 at 03:49:10PM +0800, Shawn Guo wrote: > On Mon, Oct 03, 2016 at 12:44:29PM -0500, Rob Herring wrote: > > > +Example: > > > + > > > +vou: vou at 1440000 { > > > + compatible = "zte,zx296718-vou"; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + reg = <0x1440000 0x10000>; > > > + ranges; > > > > You still have overlapping addresses. Explicitly list the sub ranges in > > reg here used by the VOU driver if the driver usage doesn't overlap. If > > there is overlap (2 drivers accessing the same range), then you need > > some APIs between the components (or possibly regmap). > > The driver matching "zte,zx296718-vou" doesn't map or access the any > 'reg' address. The 'reg' property here is more like a hint telling > that the VOU block covers the address space of all child devices. > > I will simply drop the 'reg' property here. > > > Also, don't do an empty ranges here. Fill it in so the child nodes are > > just offsets of 0x1440000 > > Okay. I thought that empty 'ranges' is fine as long as parent and child > address spaces are identical (1:1 mapping). It is fine, but it's just better policy to limit the scope of things. > So with your suggestion, I made the changes below. Let me know if this > is still not what you are asking for. Looks fine. With that, Acked-by: Rob Herring > > Shawn > > -----8<----------------- > > diff --git a/Documentation/devicetree/bindings/display/zte,vou.txt b/Documentation/devicetree/bindings/display/zte,vou.txt > index d03ba4c4810c..6bb4ab2517ef 100644 > --- a/Documentation/devicetree/bindings/display/zte,vou.txt > +++ b/Documentation/devicetree/bindings/display/zte,vou.txt > @@ -56,14 +56,13 @@ vou: vou at 1440000 { > compatible = "zte,zx296718-vou"; > #address-cells = <1>; > #size-cells = <1>; > - reg = <0x1440000 0x10000>; > - ranges; > + ranges = <0 0x1440000 0x10000>; > > - dpc: dpc at 1440000 { > + dpc: dpc at 0 { > compatible = "zte,zx296718-dpc"; > - reg = <0x1440000 0x1000>, <0x1441000 0x1000>, > - <0x1445000 0x1000>, <0x1446000 0x1000>, > - <0x144a000 0x1000>; > + reg = <0x0000 0x1000>, <0x1000 0x1000>, > + <0x5000 0x1000>, <0x6000 0x1000>, > + <0xa000 0x1000>; > reg-names = "osd", "timing_ctrl", > "dtrc", "vou_ctrl", > "otfppu"; > @@ -74,9 +73,9 @@ vou: vou at 1440000 { > "main_wclk", "aux_wclk"; > }; > > - hdmi: hdmi at 144c000 { > + hdmi: hdmi at c000 { > compatible = "zte,zx296718-hdmi"; > - reg = <0x144c000 0x4000>; > + reg = <0xc000 0x4000>; > interrupts = ; > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/2] dt-bindings: add bindings doc for ZTE VOU display controller Date: Mon, 10 Oct 2016 16:48:21 -0500 Message-ID: <20161010214821.GA17551@rob-hp-laptop> References: <1474727185-24180-1-git-send-email-shawn.guo@linaro.org> <1474727185-24180-2-git-send-email-shawn.guo@linaro.org> <20161003174429.GA26054@rob-hp-laptop> <20161009074910.GA15400@tiger> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161009074910.GA15400@tiger> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shawn Guo Cc: Mark Rutland , devicetree@vger.kernel.org, Daniel Vetter , Baoyou Xie , dri-devel@lists.freedesktop.org, Jun Nie , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org T24gU3VuLCBPY3QgMDksIDIwMTYgYXQgMDM6NDk6MTBQTSArMDgwMCwgU2hhd24gR3VvIHdyb3Rl Ogo+IE9uIE1vbiwgT2N0IDAzLCAyMDE2IGF0IDEyOjQ0OjI5UE0gLTA1MDAsIFJvYiBIZXJyaW5n IHdyb3RlOgo+ID4gPiArRXhhbXBsZToKPiA+ID4gKwo+ID4gPiArdm91OiB2b3VAMTQ0MDAwMCB7 Cj4gPiA+ICsJY29tcGF0aWJsZSA9ICJ6dGUsengyOTY3MTgtdm91IjsKPiA+ID4gKwkjYWRkcmVz cy1jZWxscyA9IDwxPjsKPiA+ID4gKwkjc2l6ZS1jZWxscyA9IDwxPjsKPiA+ID4gKwlyZWcgPSA8 MHgxNDQwMDAwIDB4MTAwMDA+Owo+ID4gPiArCXJhbmdlczsKPiA+IAo+ID4gWW91IHN0aWxsIGhh dmUgb3ZlcmxhcHBpbmcgYWRkcmVzc2VzLiBFeHBsaWNpdGx5IGxpc3QgdGhlIHN1YiByYW5nZXMg aW4gCj4gPiByZWcgaGVyZSB1c2VkIGJ5IHRoZSBWT1UgZHJpdmVyIGlmIHRoZSBkcml2ZXIgdXNh Z2UgZG9lc24ndCBvdmVybGFwLiBJZiAKPiA+IHRoZXJlIGlzIG92ZXJsYXAgKDIgZHJpdmVycyBh Y2Nlc3NpbmcgdGhlIHNhbWUgcmFuZ2UpLCB0aGVuIHlvdSBuZWVkIAo+ID4gc29tZSBBUElzIGJl dHdlZW4gdGhlIGNvbXBvbmVudHMgKG9yIHBvc3NpYmx5IHJlZ21hcCkuCj4gCj4gVGhlIGRyaXZl ciBtYXRjaGluZyAienRlLHp4Mjk2NzE4LXZvdSIgZG9lc24ndCBtYXAgb3IgYWNjZXNzIHRoZSBh bnkKPiAncmVnJyBhZGRyZXNzLiAgVGhlICdyZWcnIHByb3BlcnR5IGhlcmUgaXMgbW9yZSBsaWtl IGEgaGludCB0ZWxsaW5nCj4gdGhhdCB0aGUgVk9VIGJsb2NrIGNvdmVycyB0aGUgYWRkcmVzcyBz cGFjZSBvZiBhbGwgY2hpbGQgZGV2aWNlcy4KPiAKPiBJIHdpbGwgc2ltcGx5IGRyb3AgdGhlICdy ZWcnIHByb3BlcnR5IGhlcmUuCj4gCj4gPiBBbHNvLCBkb24ndCBkbyBhbiBlbXB0eSByYW5nZXMg aGVyZS4gRmlsbCBpdCBpbiBzbyB0aGUgY2hpbGQgbm9kZXMgYXJlIAo+ID4ganVzdCBvZmZzZXRz IG9mIDB4MTQ0MDAwMAo+IAo+IE9rYXkuICBJIHRob3VnaHQgdGhhdCBlbXB0eSAncmFuZ2VzJyBp cyBmaW5lIGFzIGxvbmcgYXMgcGFyZW50IGFuZCBjaGlsZAo+IGFkZHJlc3Mgc3BhY2VzIGFyZSBp ZGVudGljYWwgKDE6MSBtYXBwaW5nKS4KCkl0IGlzIGZpbmUsIGJ1dCBpdCdzIGp1c3QgYmV0dGVy IHBvbGljeSB0byBsaW1pdCB0aGUgc2NvcGUgb2YgdGhpbmdzLgoKPiBTbyB3aXRoIHlvdXIgc3Vn Z2VzdGlvbiwgSSBtYWRlIHRoZSBjaGFuZ2VzIGJlbG93LiAgTGV0IG1lIGtub3cgaWYgdGhpcwo+ IGlzIHN0aWxsIG5vdCB3aGF0IHlvdSBhcmUgYXNraW5nIGZvci4KCkxvb2tzIGZpbmUuIFdpdGgg dGhhdCwKCkFja2VkLWJ5OiBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgoKPiAKPiBTaGF3 bgo+IAo+IC0tLS0tODwtLS0tLS0tLS0tLS0tLS0tLQo+IAo+IGRpZmYgLS1naXQgYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS96dGUsdm91LnR4dCBiL0RvY3VtZW50 YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3p0ZSx2b3UudHh0Cj4gaW5kZXggZDAz YmE0YzQ4MTBjLi42YmI0YWIyNTE3ZWYgMTAwNjQ0Cj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvenRlLHZvdS50eHQKPiArKysgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS96dGUsdm91LnR4dAo+IEBAIC01NiwxNCArNTYs MTMgQEAgdm91OiB2b3VAMTQ0MDAwMCB7Cj4gICAgICAgICBjb21wYXRpYmxlID0gInp0ZSx6eDI5 NjcxOC12b3UiOwo+ICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gICAgICAgICAjc2l6 ZS1jZWxscyA9IDwxPjsKPiAtICAgICAgIHJlZyA9IDwweDE0NDAwMDAgMHgxMDAwMD47Cj4gLSAg ICAgICByYW5nZXM7Cj4gKyAgICAgICByYW5nZXMgPSA8MCAweDE0NDAwMDAgMHgxMDAwMD47Cj4g IAo+IC0gICAgICAgZHBjOiBkcGNAMTQ0MDAwMCB7Cj4gKyAgICAgICBkcGM6IGRwY0AwIHsKPiAg ICAgICAgICAgICAgICAgY29tcGF0aWJsZSA9ICJ6dGUsengyOTY3MTgtZHBjIjsKPiAtICAgICAg ICAgICAgICAgcmVnID0gPDB4MTQ0MDAwMCAweDEwMDA+LCA8MHgxNDQxMDAwIDB4MTAwMD4sCj4g LSAgICAgICAgICAgICAgICAgICAgIDwweDE0NDUwMDAgMHgxMDAwPiwgPDB4MTQ0NjAwMCAweDEw MDA+LAo+IC0gICAgICAgICAgICAgICAgICAgICA8MHgxNDRhMDAwIDB4MTAwMD47Cj4gKyAgICAg ICAgICAgICAgIHJlZyA9IDwweDAwMDAgMHgxMDAwPiwgPDB4MTAwMCAweDEwMDA+LAo+ICsgICAg ICAgICAgICAgICAgICAgICA8MHg1MDAwIDB4MTAwMD4sIDwweDYwMDAgMHgxMDAwPiwKPiArICAg ICAgICAgICAgICAgICAgICAgPDB4YTAwMCAweDEwMDA+Owo+ICAgICAgICAgICAgICAgICByZWct bmFtZXMgPSAib3NkIiwgInRpbWluZ19jdHJsIiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgImR0cmMiLCAidm91X2N0cmwiLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAib3Rm cHB1IjsKPiBAQCAtNzQsOSArNzMsOSBAQCB2b3U6IHZvdUAxNDQwMDAwIHsKPiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAibWFpbl93Y2xrIiwgImF1eF93Y2xrIjsKPiAgICAgICAgIH07 Cj4gIAo+IC0gICAgICAgaGRtaTogaGRtaUAxNDRjMDAwIHsKPiArICAgICAgIGhkbWk6IGhkbWlA YzAwMCB7Cj4gICAgICAgICAgICAgICAgIGNvbXBhdGlibGUgPSAienRlLHp4Mjk2NzE4LWhkbWki Owo+IC0gICAgICAgICAgICAgICByZWcgPSA8MHgxNDRjMDAwIDB4NDAwMD47Cj4gKyAgICAgICAg ICAgICAgIHJlZyA9IDwweGMwMDAgMHg0MDAwPjsKPiAgICAgICAgICAgICAgICAgaW50ZXJydXB0 cyA9IDxHSUNfU1BJIDgyIElSUV9UWVBFX0VER0VfUklTSU5HPjsKPiAKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==