Re: openpower.xyz updates

[Chris Smart <chris@distroguy.com>]

On Tue, Oct 11, 2016 at 01:00:29PM +1100, Chris Smart wrote:
>On Mon, Oct 10, 2016 at 08:43:43PM -0500, Andrew Geissler wrote:
>>On Mon, Oct 10, 2016 at 8:36 PM, Chris Smart <chris@distroguy.com> wrote:
>>>On Tue, Oct 11, 2016 at 10:14:18AM +1030, Andrew Jeffery wrote:
>>>>
>>>>On Mon, 2016-10-10 at 11:09 -0500, Andrew Geissler wrote:
>>>>>
>>>>>I noticed our gerrit trigger job to verify userid's was broken again
>>>>>this morning.  Looks like the trouble plugin (Git Client Plugin) was
>>>>>upgraded again to the latest version.  Anyone out there know why/who
>>>>>did it?  I'm going to put us back to 1.19.7 per my earlier comments.
>>>>
>>>>
>>>>Joel and Chris Smart were looking at this yesterday. A job broke:
>>>>
>>>>https://openpower.xyz/job/openpower-op-build/184/console
>>>>
>>>>According to Chris it broke because of:
>>>>
>>>>https://bugs.eclipse.org/bugs/show_bug.cgi?id=428039
>>>>
>>>>   15:58 < csmart> joel, basically release() was replaced with close()
>>>>   and so any plugin that uses git needs to be updated
>>>>
>>>>Looks like we're stuck between a rock and a hard place.
>>>>
>>>
>>>Yep, I updated the git client plugin because openpower build couldn't
>>>perform any git operations.
>>>
>>>I didn't expect that to affect any comms with other Jenkins instances
>>>though, that is strange. Why does the gerrit userid plugin rely on on
>>>git client? Do you have a log or backtrace? Might help to try and track
>>>it down.
>>
>>Here's the fail, it's a weird one:
>>https://openpower.xyz/job/openbmc-userid-verify/795/console
>>
>>07:05:18  > git rev-parse FETCH_HEAD^{commit} # timeout=10
>>07:05:18 FATAL: org.eclipse.jgit.revwalk.RevWalk.release()V
>>07:05:18 java.lang.NoSuchMethodError:
>>org.eclipse.jgit.revwalk.RevWalk.release()V
>>07:05:18 at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerBuildChooser$1.invoke(GerritTriggerBuildChooser.java:185)
>>07:05:18 at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerBuildChooser$1.invoke(GerritTriggerBuildChooser.java:166)
>>07:05:18 at org.jenkinsci.plugins.gitclient.AbstractGitAPIImpl.withRepository(AbstractGitAPIImpl.java:27)
>>07:05:18 at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.withRepository(CliGitAPIImpl.java:64)
>>07:05:18 at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerBuildChooser.getFirstParent(GerritTriggerBuildChooser.java:166)
>>...
>>
>>No bug report on my part since I didn't think it was that big an
>>issue....I have been proven wrong.  I thing we have an imminent call,
>>lets touch base there and I'll get one open if needed.
>>
>
>Yeah, so I think that's the same issue; release() was replaced with
>close() in jgit and so any plugin that uses that needs to be updated.
>
>This is what was breaking the openpower build and was fixed by updating
>the git client plugin.
>
>The log snippet you provided suggests to me that the gerrit trigger
>plugin needs to be updated, you can see it's trying to call that
>release() here:
>
>07:05:18 FATAL: org.eclipse.jgit.revwalk.RevWalk.release()V
>07:05:18 java.lang.NoSuchMethodError: org.eclipse.jgit.revwalk.RevWalk.release()V
>07:05:18 at com.sonyericsson.hudson.plugins.gerrit.trigger.hudsontrigger.GerritTriggerBuildChooser$1.invoke(GerritTriggerBuildChooser.java:185)
>

And to that effect:

Release 2.22.0 of GerritTrigger fixes this:

https://wiki.jenkins-ci.org/display/JENKINS/Gerrit+Trigger#GerritTrigger-Version2.22.0%28releasedAug172016%29


Version 2.22.0 (released Aug 17 2016)
 * Prepare for git client plugin 2.0.0 coexistence with 1.x (pull #296)

pull #296:
https://github.com/jenkinsci/gerrit-trigger-plugin/pull/296

So I would expect that updating gitclient and also gerrit-trigger would
solve these issues.

I don't know about the userid thing though - if you have a log for that,
feel free to send it through and I'll take a look.

-c

>-c
>
>>>
>>>-c
>>>
>>>
>>>>Cheers,
>>>>
>>>>Andrew
>>>>
>>>>>
>>>>>There's no fix per-se for this, jenkins is always a bit hit or miss
>>>>>with it's latest LTS version working with the latest plugins.  Best
>>>>>thing we can do is when we schedule our next jenkins LTS upgrade, to
>>>>>try all the latest plugins again.
>>>>>
>>>>>Andrew
>>>>>
>>>>>On Fri, Sep 30, 2016 at 8:12 AM, Patrick Williams <patrick@stwcx.xyz>
>>>>>wrote:
>>>>>>
>>>>>> On Fri, Sep 30, 2016 at 11:16:08AM +0930, Joel Stanley wrote:
>>>>>> >
>>>>>> > Okay. Do we plan to test the individual projects as part of an
>>>>>> > openbmc/openbmc build in the future?
>>>>>> >
>>>>>> Yes.  https://github.com/openbmc/openbmc/issues/382
>>>>>>
>>>>>> --
>>>>>> Patrick Williams
>>>>>_______________________________________________
>>>>>openbmc mailing list
>>>>>openbmc@lists.ozlabs.org
>>>>>https://lists.ozlabs.org/listinfo/openbmc
>>>
>>>
>>>