From: Greg KH <gregkh@linuxfoundation.org>
To: Elise Lennion <elise.lennion@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: sm750fb: Merge ddk750_help.* into ddk750_chip.*.
Date: Tue, 11 Oct 2016 08:13:49 +0200 [thread overview]
Message-ID: <20161011061349.GB3608@kroah.com> (raw)
In-Reply-To: <20161011000955.GA16743@lennorien.com>
On Mon, Oct 10, 2016 at 09:09:55PM -0300, Elise Lennion wrote:
> The file ddk750_help.c contained only one function declaration,
> so it was merged into ddk750_chip.c to simplify the driver.
>
> Also, ddk750_help.h was merged into ddk750_chip.h to keep consistency.
>
> Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
> ---
> drivers/staging/sm750fb/Makefile | 2 +-
> drivers/staging/sm750fb/ddk750.h | 1 -
> drivers/staging/sm750fb/ddk750_chip.c | 15 ++++++++++++++-
> drivers/staging/sm750fb/ddk750_chip.h | 10 ++++++++++
> drivers/staging/sm750fb/ddk750_display.c | 2 +-
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> drivers/staging/sm750fb/ddk750_help.c | 17 -----------------
> drivers/staging/sm750fb/ddk750_help.h | 21 ---------------------
> drivers/staging/sm750fb/ddk750_hwi2c.c | 2 +-
> drivers/staging/sm750fb/ddk750_mode.c | 1 -
> drivers/staging/sm750fb/ddk750_power.c | 2 +-
> drivers/staging/sm750fb/ddk750_swi2c.c | 2 +-
> 12 files changed, 30 insertions(+), 47 deletions(-)
> delete mode 100644 drivers/staging/sm750fb/ddk750_help.c
> delete mode 100644 drivers/staging/sm750fb/ddk750_help.h
>
> diff --git a/drivers/staging/sm750fb/Makefile b/drivers/staging/sm750fb/Makefile
> index dcce3f4..4d781f7 100644
> --- a/drivers/staging/sm750fb/Makefile
> +++ b/drivers/staging/sm750fb/Makefile
> @@ -1,4 +1,4 @@
> obj-$(CONFIG_FB_SM750) += sm750fb.o
>
> sm750fb-objs := sm750.o sm750_hw.o sm750_accel.o sm750_cursor.o ddk750_chip.o ddk750_power.o ddk750_mode.o
> -sm750fb-objs += ddk750_display.o ddk750_help.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
> +sm750fb-objs += ddk750_display.o ddk750_swi2c.o ddk750_sii164.o ddk750_dvi.o ddk750_hwi2c.o
> diff --git a/drivers/staging/sm750fb/ddk750.h b/drivers/staging/sm750fb/ddk750.h
> index 2c10a08..0566911 100644
> --- a/drivers/staging/sm750fb/ddk750.h
> +++ b/drivers/staging/sm750fb/ddk750.h
> @@ -16,7 +16,6 @@
> #include "ddk750_chip.h"
> #include "ddk750_display.h"
> #include "ddk750_power.h"
> -#include "ddk750_help.h"
> #ifdef USE_HW_I2C
> #include "ddk750_hwi2c.h"
> #endif
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index c62ebc1..6c02f1d 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -1,13 +1,16 @@
> #include <linux/kernel.h>
> #include <linux/sizes.h>
>
> -#include "ddk750_help.h"
> #include "ddk750_reg.h"
> #include "ddk750_chip.h"
> #include "ddk750_power.h"
>
> #define MHz(x) ((x) * 1000000)
>
> +void __iomem *mmio750;
Yes, this needs to be as-is, to make the horrid macros work properly.
> +char revId750;
This variable can be static, right?
> +unsigned short devId750;
As can this one? And is this one even really needed?
Are either of them really needed?
thanks,
greg k-h
prev parent reply other threads:[~2016-10-11 6:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 0:09 [PATCH] staging: sm750fb: Merge ddk750_help.* into ddk750_chip.* Elise Lennion
2016-10-11 6:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011061349.GB3608@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=elise.lennion@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.