From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: re: qed: Add RoCE ll2 & GSI support
Date: Tue, 11 Oct 2016 07:33:05 +0000 [thread overview]
Message-ID: <20161011073305.GA19247@mwanda> (raw)
Hello Ram Amrani,
This is a semi-automatic email about new static checker warnings.
The patch abd49676c707: "qed: Add RoCE ll2 & GSI support" from Oct 1,
2016, leads to the following Smatch complaint:
drivers/net/ethernet/qlogic/qed/qed_roce.c:2812 qed_roce_ll2_stop()
warn: variable dereferenced before check 'cdev' (see line 2808)
drivers/net/ethernet/qlogic/qed/qed_roce.c
2807 {
2808 struct qed_hwfn *hwfn = QED_LEADING_HWFN(cdev);
2809 struct qed_roce_ll2_info *roce_ll2 = hwfn->ll2;
^^^^^^^^^
Deref.
2810 int rc;
2811
2812 if (!cdev) {
^^^^^
Checked too late.
2813 DP_ERR(cdev, "qed roce ll2 stop: invalid cdev\n");
2814 return -EINVAL;
regards,
dan carpenter
next reply other threads:[~2016-10-11 7:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 7:33 Dan Carpenter [this message]
2016-10-13 6:58 ` qed: Add RoCE ll2 & GSI support Amrani, Ram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011073305.GA19247@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.