From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: fix init on secondary process Date: Tue, 11 Oct 2016 11:45:38 +0200 Message-ID: <20161011094538.GO17252@6wind.com> References: <1475072658-29534-1-git-send-email-ogournet@corp.free.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Olivier Gournet Return-path: Received: from mail-lf0-f48.google.com (mail-lf0-f48.google.com [209.85.215.48]) by dpdk.org (Postfix) with ESMTP id C344F72FB for ; Tue, 11 Oct 2016 11:45:45 +0200 (CEST) Received: by mail-lf0-f48.google.com with SMTP id b75so32247578lfg.3 for ; Tue, 11 Oct 2016 02:45:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1475072658-29534-1-git-send-email-ogournet@corp.free.fr> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, Secondary process support's got overlooked during this refactoring, thanks for the patch. However can you describe the issue you're addressing as part of the commit log? I think problems started when txq got mistakenly converted to primary_txq_ctrl in 21c8bb4928c9 ("net/mlx5: split Tx queue structure"), you may add a Fixes line for that one as well. Otherwise, this patch looks fine to me. On Wed, Sep 28, 2016 at 04:24:18PM +0200, Olivier Gournet wrote: > Fixes: 1d88ba171942 ("net/mlx5: refactor Tx data path") > > Signed-off-by: Olivier Gournet > --- > drivers/net/mlx5/mlx5_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c > index 130e15d..6f39965 100644 > --- a/drivers/net/mlx5/mlx5_ethdev.c > +++ b/drivers/net/mlx5/mlx5_ethdev.c > @@ -1308,11 +1308,13 @@ mlx5_secondary_data_setup(struct priv *priv) > continue; > primary_txq_ctrl = container_of(primary_txq, > struct txq_ctrl, txq); > - txq_ctrl = rte_calloc_socket("TXQ", 1, sizeof(*txq_ctrl), 0, > + txq_ctrl = rte_calloc_socket("TXQ", 1, sizeof(*txq_ctrl) + > + primary_txq->elts_n * > + sizeof(struct rte_mbuf *), 0, > primary_txq_ctrl->socket); > if (txq_ctrl != NULL) { > if (txq_ctrl_setup(priv->dev, > - primary_txq_ctrl, > + txq_ctrl, > primary_txq->elts_n, > primary_txq_ctrl->socket, > NULL) == 0) { > -- > 2.1.4 -- Adrien Mazarguil 6WIND