From: Dan Carpenter <dan.carpenter@oracle.com>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [bug report] staging: lustre: create striped directory
Date: Tue, 11 Oct 2016 14:37:53 +0300 [thread overview]
Message-ID: <20161011113752.GA25834@mwanda> (raw)
Hello wang di,
The patch 2de353860782: "staging: lustre: create striped directory"
from Aug 16, 2016, leads to the following static checker warning:
drivers/staging/lustre/lustre/llite/namei.c:294 ll_md_blocking_ast()
warn: 'master_inode' isn't an ERR_PTR
drivers/staging/lustre/lustre/llite/namei.c
287
288 hash = cl_fid_build_ino(&lli->lli_pfid,
289 ll_need_32bit_api(ll_i2sbi(inode)));
290
291 master_inode = ilookup5(inode->i_sb, hash,
292 ll_test_inode_by_fid,
293 (void *)&lli->lli_pfid);
294 if (master_inode && !IS_ERR(master_inode)) {
^^^^^^^^^^^^^^^^^^^^
ilookup5() never returns ERR_PTRs.
295 ll_invalidate_negative_children(master_inode);
296 iput(master_inode);
297 }
regards,
dan carpenter
next reply other threads:[~2016-10-11 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-11 11:37 Dan Carpenter [this message]
[not found] ` <D4225DB9.44EC%di.wang@intel.com>
2016-10-12 9:17 ` [lustre-devel] [bug report] staging: lustre: create striped directory Dan Carpenter
2016-10-13 22:38 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011113752.GA25834@mwanda \
--to=dan.carpenter@oracle.com \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.