From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49537) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btxv4-0002UA-IM for qemu-devel@nongnu.org; Tue, 11 Oct 2016 10:20:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1btxv0-0005Om-LN for qemu-devel@nongnu.org; Tue, 11 Oct 2016 10:20:38 -0400 Received: from smtp.citrix.com ([66.165.176.89]:44419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1btxv0-0005Nh-Cs for qemu-devel@nongnu.org; Tue, 11 Oct 2016 10:20:34 -0400 Date: Tue, 11 Oct 2016 15:20:30 +0100 From: Anthony PERARD Message-ID: <20161011142030.GC1812@perard.uk.xensource.com> References: <1475563424-6604-1-git-send-email-emilcondrea@gmail.com> <1475563424-6604-3-git-send-email-emilcondrea@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1475563424-6604-3-git-send-email-emilcondrea@gmail.com> Subject: Re: [Qemu-devel] [PATCH 02/15] xen: Fix coding style warnings List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Emil Condrea Cc: qemu-devel@nongnu.org, xuquan8@huawei.com, wei.liu2@citrix.com, stefanb@linux.vnet.ibm.com, sstabellini@kernel.org, xen-devel@lists.xen.org, dgdegra@tycho.nsa.gov, eblake@redhat.com On Tue, Oct 04, 2016 at 09:43:31AM +0300, Emil Condrea wrote: > Fixes: > * WARNING: line over 80 characters > > Signed-off-by: Emil Condrea > --- > hw/block/xen_disk.c | 3 ++- > hw/char/xen_console.c | 6 ++++-- > hw/display/xenfb.c | 30 ++++++++++++++++++++---------- > hw/net/xen_nic.c | 12 ++++++++---- > hw/xen/xen_backend.c | 15 ++++++++++----- > include/hw/xen/xen_backend.h | 8 +++++--- > 6 files changed, 49 insertions(+), 25 deletions(-) > > diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c > index 5aa350a..24edeb2 100644 > --- a/hw/block/xen_disk.c > +++ b/hw/block/xen_disk.c > @@ -1068,7 +1068,8 @@ static int blk_connect(struct XenDevice *xendev) > blk_set_enable_write_cache(blkdev->blk, !writethrough); > } else { > /* setup via qemu cmdline -> already setup for us */ > - xen_be_printf(&blkdev->xendev, 2, "get configured bdrv (cmdline setup)\n"); > + xen_be_printf(&blkdev->xendev, 2, > + "get configured bdrv (cmdline setup)\n"); Arguments are usually aligned with the first one, so there is one missing space. > blkdev->blk = blk_by_legacy_dinfo(blkdev->dinfo); > if (blk_is_read_only(blkdev->blk) && !readonly) { > xen_be_printf(&blkdev->xendev, 0, "Unexpected read-only drive"); > diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c > index 4e35c82..399bb5d 100644 > --- a/hw/char/xen_console.c > +++ b/hw/char/xen_console.c > @@ -156,7 +156,8 @@ static void xencons_send(struct XenConsole *con) > if (len < 1) { > if (!con->backlog) { > con->backlog = 1; > - xen_be_printf(&con->xendev, 1, "backlog piling up, nobody listening?\n"); > + xen_be_printf(&con->xendev, 1, > + "backlog piling up, nobody listening?\n"); same here and other places. > } > } else { > buffer_advance(&con->buffer, len); > @@ -247,7 +248,8 @@ static int con_initialise(struct XenDevice *xendev) > } > } > > - xen_be_printf(xendev, 1, "ring mfn %d, remote port %d, local port %d, limit %zd\n", > + xen_be_printf(xendev, 1, > + "ring mfn %d, remote port %d, local port %d, limit %zd\n", > con->ring_ref, > con->xendev.remote_port, > con->xendev.local_port, > diff --git a/hw/xen/xen_backend.c b/hw/xen/xen_backend.c > index 545ee47..0aca6ae 100644 > --- a/hw/xen/xen_backend.c > +++ b/hw/xen/xen_backend.c > @@ -205,7 +206,8 @@ int xenstore_read_fe_int(struct XenDevice *xendev, const char *node, int *ival) > return xenstore_read_int(xendev->fe, node, ival); > } > > -int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node, uint64_t *uval) > +int xenstore_read_fe_uint64(struct XenDevice *xendev, const char *node, > + uint64_t *uval) Same here, it would be better to align the second line with the first parameter. > { > return xenstore_read_uint64(xendev->fe, node, uval); > } -- Anthony PERARD From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony PERARD Subject: Re: [PATCH 02/15] xen: Fix coding style warnings Date: Tue, 11 Oct 2016 15:20:30 +0100 Message-ID: <20161011142030.GC1812@perard.uk.xensource.com> References: <1475563424-6604-1-git-send-email-emilcondrea@gmail.com> <1475563424-6604-3-git-send-email-emilcondrea@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1475563424-6604-3-git-send-email-emilcondrea@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Emil Condrea Cc: xuquan8@huawei.com, sstabellini@kernel.org, wei.liu2@citrix.com, stefanb@linux.vnet.ibm.com, qemu-devel@nongnu.org, xen-devel@lists.xen.org, dgdegra@tycho.nsa.gov, eblake@redhat.com List-Id: xen-devel@lists.xenproject.org T24gVHVlLCBPY3QgMDQsIDIwMTYgYXQgMDk6NDM6MzFBTSArMDMwMCwgRW1pbCBDb25kcmVhIHdy b3RlOgo+IEZpeGVzOgo+ICAqIFdBUk5JTkc6IGxpbmUgb3ZlciA4MCBjaGFyYWN0ZXJzCj4gCj4g U2lnbmVkLW9mZi1ieTogRW1pbCBDb25kcmVhIDxlbWlsY29uZHJlYUBnbWFpbC5jb20+Cj4gLS0t Cj4gIGh3L2Jsb2NrL3hlbl9kaXNrLmMgICAgICAgICAgfCAgMyArKy0KPiAgaHcvY2hhci94ZW5f Y29uc29sZS5jICAgICAgICB8ICA2ICsrKystLQo+ICBody9kaXNwbGF5L3hlbmZiLmMgICAgICAg ICAgIHwgMzAgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tCj4gIGh3L25ldC94ZW5fbmlj LmMgICAgICAgICAgICAgfCAxMiArKysrKysrKy0tLS0KPiAgaHcveGVuL3hlbl9iYWNrZW5kLmMg ICAgICAgICB8IDE1ICsrKysrKysrKystLS0tLQo+ICBpbmNsdWRlL2h3L3hlbi94ZW5fYmFja2Vu ZC5oIHwgIDggKysrKystLS0KPiAgNiBmaWxlcyBjaGFuZ2VkLCA0OSBpbnNlcnRpb25zKCspLCAy NSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvaHcvYmxvY2sveGVuX2Rpc2suYyBiL2h3 L2Jsb2NrL3hlbl9kaXNrLmMKPiBpbmRleCA1YWEzNTBhLi4yNGVkZWIyIDEwMDY0NAo+IC0tLSBh L2h3L2Jsb2NrL3hlbl9kaXNrLmMKPiArKysgYi9ody9ibG9jay94ZW5fZGlzay5jCj4gQEAgLTEw NjgsNyArMTA2OCw4IEBAIHN0YXRpYyBpbnQgYmxrX2Nvbm5lY3Qoc3RydWN0IFhlbkRldmljZSAq eGVuZGV2KQo+ICAgICAgICAgIGJsa19zZXRfZW5hYmxlX3dyaXRlX2NhY2hlKGJsa2Rldi0+Ymxr LCAhd3JpdGV0aHJvdWdoKTsKPiAgICAgIH0gZWxzZSB7Cj4gICAgICAgICAgLyogc2V0dXAgdmlh IHFlbXUgY21kbGluZSAtPiBhbHJlYWR5IHNldHVwIGZvciB1cyAqLwo+IC0gICAgICAgIHhlbl9i ZV9wcmludGYoJmJsa2Rldi0+eGVuZGV2LCAyLCAiZ2V0IGNvbmZpZ3VyZWQgYmRydiAoY21kbGlu ZSBzZXR1cClcbiIpOwo+ICsgICAgICAgIHhlbl9iZV9wcmludGYoJmJsa2Rldi0+eGVuZGV2LCAy LAo+ICsgICAgICAgICAgICAgICAgICAgICAiZ2V0IGNvbmZpZ3VyZWQgYmRydiAoY21kbGluZSBz ZXR1cClcbiIpOwoKQXJndW1lbnRzIGFyZSB1c3VhbGx5IGFsaWduZWQgd2l0aCB0aGUgZmlyc3Qg b25lLCBzbyB0aGVyZSBpcyBvbmUKbWlzc2luZyBzcGFjZS4KCj4gICAgICAgICAgYmxrZGV2LT5i bGsgPSBibGtfYnlfbGVnYWN5X2RpbmZvKGJsa2Rldi0+ZGluZm8pOwo+ICAgICAgICAgIGlmIChi bGtfaXNfcmVhZF9vbmx5KGJsa2Rldi0+YmxrKSAmJiAhcmVhZG9ubHkpIHsKPiAgICAgICAgICAg ICAgeGVuX2JlX3ByaW50ZigmYmxrZGV2LT54ZW5kZXYsIDAsICJVbmV4cGVjdGVkIHJlYWQtb25s eSBkcml2ZSIpOwo+IGRpZmYgLS1naXQgYS9ody9jaGFyL3hlbl9jb25zb2xlLmMgYi9ody9jaGFy L3hlbl9jb25zb2xlLmMKPiBpbmRleCA0ZTM1YzgyLi4zOTliYjVkIDEwMDY0NAo+IC0tLSBhL2h3 L2NoYXIveGVuX2NvbnNvbGUuYwo+ICsrKyBiL2h3L2NoYXIveGVuX2NvbnNvbGUuYwo+IEBAIC0x NTYsNyArMTU2LDggQEAgc3RhdGljIHZvaWQgeGVuY29uc19zZW5kKHN0cnVjdCBYZW5Db25zb2xl ICpjb24pCj4gICAgICBpZiAobGVuIDwgMSkgewo+ICAgICAgICAgIGlmICghY29uLT5iYWNrbG9n KSB7Cj4gICAgICAgICAgICAgIGNvbi0+YmFja2xvZyA9IDE7Cj4gLSAgICAgICAgICAgIHhlbl9i ZV9wcmludGYoJmNvbi0+eGVuZGV2LCAxLCAiYmFja2xvZyBwaWxpbmcgdXAsIG5vYm9keSBsaXN0 ZW5pbmc/XG4iKTsKPiArICAgICAgICAgICAgeGVuX2JlX3ByaW50ZigmY29uLT54ZW5kZXYsIDEs Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAiYmFja2xvZyBwaWxpbmcgdXAsIG5vYm9keSBs aXN0ZW5pbmc/XG4iKTsKCnNhbWUgaGVyZSBhbmQgb3RoZXIgcGxhY2VzLgoKPiAgICAgICAgICB9 Cj4gICAgICB9IGVsc2Ugewo+ICAgICAgICAgIGJ1ZmZlcl9hZHZhbmNlKCZjb24tPmJ1ZmZlciwg bGVuKTsKPiBAQCAtMjQ3LDcgKzI0OCw4IEBAIHN0YXRpYyBpbnQgY29uX2luaXRpYWxpc2Uoc3Ry dWN0IFhlbkRldmljZSAqeGVuZGV2KQo+ICAgICAgICAgIH0KPiAgICAgIH0KPiAgCj4gLSAgICB4 ZW5fYmVfcHJpbnRmKHhlbmRldiwgMSwgInJpbmcgbWZuICVkLCByZW1vdGUgcG9ydCAlZCwgbG9j YWwgcG9ydCAlZCwgbGltaXQgJXpkXG4iLAo+ICsgICAgeGVuX2JlX3ByaW50Zih4ZW5kZXYsIDEs Cj4gKyAgICAgICAgICAgICAgICAgInJpbmcgbWZuICVkLCByZW1vdGUgcG9ydCAlZCwgbG9jYWwg cG9ydCAlZCwgbGltaXQgJXpkXG4iLAo+ICAJCSAgY29uLT5yaW5nX3JlZiwKPiAgCQkgIGNvbi0+ eGVuZGV2LnJlbW90ZV9wb3J0LAo+ICAJCSAgY29uLT54ZW5kZXYubG9jYWxfcG9ydCwKPiBkaWZm IC0tZ2l0IGEvaHcveGVuL3hlbl9iYWNrZW5kLmMgYi9ody94ZW4veGVuX2JhY2tlbmQuYwo+IGlu ZGV4IDU0NWVlNDcuLjBhY2E2YWUgMTAwNjQ0Cj4gLS0tIGEvaHcveGVuL3hlbl9iYWNrZW5kLmMK PiArKysgYi9ody94ZW4veGVuX2JhY2tlbmQuYwo+IEBAIC0yMDUsNyArMjA2LDggQEAgaW50IHhl bnN0b3JlX3JlYWRfZmVfaW50KHN0cnVjdCBYZW5EZXZpY2UgKnhlbmRldiwgY29uc3QgY2hhciAq bm9kZSwgaW50ICppdmFsKQo+ICAgICAgcmV0dXJuIHhlbnN0b3JlX3JlYWRfaW50KHhlbmRldi0+ ZmUsIG5vZGUsIGl2YWwpOwo+ICB9Cj4gIAo+IC1pbnQgeGVuc3RvcmVfcmVhZF9mZV91aW50NjQo c3RydWN0IFhlbkRldmljZSAqeGVuZGV2LCBjb25zdCBjaGFyICpub2RlLCB1aW50NjRfdCAqdXZh bCkKPiAraW50IHhlbnN0b3JlX3JlYWRfZmVfdWludDY0KHN0cnVjdCBYZW5EZXZpY2UgKnhlbmRl diwgY29uc3QgY2hhciAqbm9kZSwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB1aW50NjRfdCAqdXZhbCkKClNhbWUgaGVyZSwgaXQgd291 bGQgYmUgYmV0dGVyIHRvIGFsaWduIHRoZSBzZWNvbmQgbGluZSB3aXRoIHRoZSBmaXJzdApwYXJh bWV0ZXIuCgo+ICB7Cj4gICAgICByZXR1cm4geGVuc3RvcmVfcmVhZF91aW50NjQoeGVuZGV2LT5m ZSwgbm9kZSwgdXZhbCk7Cj4gIH0KCi0tIApBbnRob255IFBFUkFSRAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==